All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Edward Z. Yang" <edwardzyang@thewritingpot.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, msysGit <msysgit@googlegroups.com>, junio@pobox.com
Subject: Re: [PATCH 06/12] connect: Fix custom ports with plink (Putty's ssh)
Date: Wed, 02 Jul 2008 23:07:09 -0400	[thread overview]
Message-ID: <486C425D.8090904@thewritingpot.com> (raw)


Johannes Sixt wrote:
 > What about installing a wrapper script, plinkssh, that does this:
 > [snip]

Well, the patch is shorter :-)

Joking aside, it's a good question. I guess I prefer the patch because:

1. It's been tested, it works. I haven't tried the script yet, so I 
don't know if it works.

2. Git historically doesn't use bash, so the script would have to be 
rewritten in Perl or plain sh or tcl or something.

3. It's less brittle than the wrapper script if we decide to have Git 
pass more params to OpenSSH.

4. It's "more native".

I don't know if these are compelling enough reasons, though.

(cc'ed everyone else, whoops)

             reply	other threads:[~2008-07-03  3:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-03  3:07 Edward Z. Yang [this message]
2008-07-03 12:29 ` [PATCH 06/12] connect: Fix custom ports with plink (Putty's ssh) Johannes Schindelin
2008-07-04 20:05   ` Edward Z. Yang
  -- strict thread matches above, loose matches on Subject: below --
2008-07-02  8:31 How to reduce remaining differences to 4msysgit? (was What's cooking in git.git (topics)) Steffen Prohaska
2008-07-02  8:32 ` [PATCH 01/12] Fake reencoding success under NO_ICONV instead of returning NULL Steffen Prohaska
2008-07-02  8:32   ` [PATCH 02/12] Do not complain about "no common commits" in an empty repo Steffen Prohaska
2008-07-02  8:32     ` [PATCH 03/12] MinGW: Convert CR/LF to LF in tag signatures Steffen Prohaska
2008-07-02  8:32       ` [PATCH 04/12] Avoid calling signal(SIGPIPE, ..) for MinGW builds Steffen Prohaska
2008-07-02  8:32         ` [PATCH 05/12] Windows(msysgit): Per default, display help as HTML in default browser Steffen Prohaska
2008-07-02  8:32           ` [PATCH 06/12] connect: Fix custom ports with plink (Putty's ssh) Steffen Prohaska
2008-07-02 19:04             ` Johannes Sixt
2008-07-03 11:10               ` Johannes Schindelin
2008-07-04  8:50                 ` Steffen Prohaska
2008-07-04  9:18               ` Junio C Hamano
2008-07-04  9:29                 ` Steffen Prohaska
2008-07-04 16:09                   ` Clifford Caoile

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=486C425D.8090904@thewritingpot.com \
    --to=edwardzyang@thewritingpot.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=junio@pobox.com \
    --cc=msysgit@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.