All of lore.kernel.org
 help / color / mirror / Atom feed
From: Celine Bourde <celine.bourde@bull.net>
To: linux-ext4@vger.kernel.org, "Jose R. Santos" <jrs@us.ibm.com>,
	cmm@us.ibm.com, "Frédéric Bohé" <frederic.bohe@bull.net>
Cc: SOLOFO RAMANGALAHY <Solofo.Ramangalahy@bull.net>,
	Jean-Pierre Dion <jean-pierre.dion@bull.net>
Subject: [PATCH][e2fsprogs][mke2fs] fix FLEX_BG offset
Date: Thu, 03 Jul 2008 10:21:02 +0200	[thread overview]
Message-ID: <486C8BEE.5030200@bull.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 819 bytes --]

This patch resolves the offset problem of the flex_bg
option when you use mke2fs tool.

For example, if you type mkfs.ext4 -I256 -O flex_bg -G32 -E test_fs <device>
and look dumpe2fs <device> result you will see an offset problem.

Group 0: (Blocks 0-32767)
Primary superblock at 0, Group descriptors at 1-5
Reserved GDT blocks at 6-1024
Block bitmap at 1025 (+1025), Inode bitmap at 1058 (+1058)
Inode table at 1090-1601 (+1090)
0 free blocks, 8181 free inodes, 2 directories
Free blocks:
Free inodes: 12-8192

Inode bitmap must start at 1025 + 32 = 1057
In all flexbg groups, the block between the last block bitmap and the 
first inode
bitmap (metatdata) is not used, which introduced a hole.

This patch corrects it.
You have to apply it on e2fsprogs (mke2fs 1.41-WIP (17-Jun-2008)) master 
branch.

Celine Bourde.

[-- Attachment #2: flexbg_offset.patch --]
[-- Type: text/x-patch, Size: 739 bytes --]

Signed-off-by: Bourde Celine <celine.bourde@bull.net>

alloc_tables.c |    8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff -rpu a/lib/ext2fs/alloc_tables.c b/lib/ext2fs/alloc_tables.c
--- a/lib/ext2fs/alloc_tables.c	2008-07-01 16:11:49.000000000 +0200
+++ b/lib/ext2fs/alloc_tables.c	2008-07-02 16:38:22.000000000 +0200
@@ -71,9 +71,11 @@ static blk_t flexbg_offset(ext2_filsys f
 				   &first_free))
 		return first_free;
 
-	if (ext2fs_get_free_blocks(fs, first_free + offset, last_blk, size,
-				   bmap, &first_free))
-		return first_free;
+	if (offset)
+		if (ext2fs_get_free_blocks(fs, first_free + offset - 1,
+					   last_blk, size, bmap,
+					   &first_free))
+			return first_free;
 
 	return first_free;
 }

             reply	other threads:[~2008-07-03 12:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-03  8:21 Celine Bourde [this message]
2008-07-03 11:55 ` [PATCH][e2fsprogs][mke2fs] fix FLEX_BG offset Jose R. Santos
2008-07-07 19:42   ` Jose R. Santos
2008-07-07 22:30     ` Theodore Tso
2008-07-07 16:46 ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=486C8BEE.5030200@bull.net \
    --to=celine.bourde@bull.net \
    --cc=Solofo.Ramangalahy@bull.net \
    --cc=cmm@us.ibm.com \
    --cc=frederic.bohe@bull.net \
    --cc=jean-pierre.dion@bull.net \
    --cc=jrs@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.