From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Thery Subject: Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory support. Date: Thu, 03 Jul 2008 14:37:49 +0200 Message-ID: <486CC81D.9010003@bull.net> References: <20080618170729.808539948@theryb.frec.bull.fr> <20080618170731.002784342@theryb.frec.bull.fr> <485F04E1.70204@gmail.com> <486706C9.9040303@gmail.com> <4869D314.5030403@gmail.com> <486A0751.9080602@gmail.com> <486AF4FA.8020805@gmail.com> <486B060C.7030607@gmail.com> <486C4515.1070007@gmail.com> <486CB051.5000507@fr.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Eric W. Biederman" Cc: Tejun Heo , Greg Kroah-Hartman , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Al Viro , Linux Containers , Daniel Lezcano , Andrew Morton List-Id: containers.vger.kernel.org Eric W. Biederman wrote: > Daniel Lezcano writes: > >> The kobject events are sent through a netlink message which is not currently per >> network namespace. Shouldn't be useful to have a way to retrieve from the >> kobject the network namespace or the uevent socket associated with it ? IMHO >> having idr in the kobject + netns pointer associated may help to handle the >> sysfs isolation and makes the uevent per namespace trivial, no ? > > Grumble. I have been conveniently been forgetting about that socket. > Similarly we have the user mode helpers to deal with. > > For this conversation there is a simple answer. All of that is in the > kobject layer, and works even when you compile sysfs out of your kernel. > Therefore it is a separate problem. And sysfs idr tags have nothing > to do with it. > It is most definitely something we need to come back to. I bet there > are some interesting interactions when you have multiple network devices > with the same name generating events. Indeed, we observed some fun things with one distro (which defines some particular udev rules) when a device called eth0 in a namespace comes back to init net :) Benjamin > > Eric > > > > > > > > > > -- B e n j a m i n T h e r y - BULL/DT/Open Software R&D http://www.bull.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756157AbYGCMhp (ORCPT ); Thu, 3 Jul 2008 08:37:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756817AbYGCMhY (ORCPT ); Thu, 3 Jul 2008 08:37:24 -0400 Received: from ecfrec.frec.bull.fr ([129.183.4.8]:43165 "EHLO ecfrec.frec.bull.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756902AbYGCMhW (ORCPT ); Thu, 3 Jul 2008 08:37:22 -0400 Message-ID: <486CC81D.9010003@bull.net> Date: Thu, 03 Jul 2008 14:37:49 +0200 From: Benjamin Thery User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: "Eric W. Biederman" Cc: Daniel Lezcano , Tejun Heo , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Al Viro , Linux Containers , Andrew Morton Subject: Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory support. References: <20080618170729.808539948@theryb.frec.bull.fr> <20080618170731.002784342@theryb.frec.bull.fr> <485F04E1.70204@gmail.com> <486706C9.9040303@gmail.com> <4869D314.5030403@gmail.com> <486A0751.9080602@gmail.com> <486AF4FA.8020805@gmail.com> <486B060C.7030607@gmail.com> <486C4515.1070007@gmail.com> <486CB051.5000507@fr.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric W. Biederman wrote: > Daniel Lezcano writes: > >> The kobject events are sent through a netlink message which is not currently per >> network namespace. Shouldn't be useful to have a way to retrieve from the >> kobject the network namespace or the uevent socket associated with it ? IMHO >> having idr in the kobject + netns pointer associated may help to handle the >> sysfs isolation and makes the uevent per namespace trivial, no ? > > Grumble. I have been conveniently been forgetting about that socket. > Similarly we have the user mode helpers to deal with. > > For this conversation there is a simple answer. All of that is in the > kobject layer, and works even when you compile sysfs out of your kernel. > Therefore it is a separate problem. And sysfs idr tags have nothing > to do with it. > It is most definitely something we need to come back to. I bet there > are some interesting interactions when you have multiple network devices > with the same name generating events. Indeed, we observed some fun things with one distro (which defines some particular udev rules) when a device called eth0 in a namespace comes back to init net :) Benjamin > > Eric > > > > > > > > > > -- B e n j a m i n T h e r y - BULL/DT/Open Software R&D http://www.bull.com