Re: Patches solving the same issue!?

[Patrick McHardy <kaber@trash.net>]

Jesper Dangaard Brouer wrote:
> I can see from the list that Thomas Jacob <jacob@internet24.de>, and I
> have just posted patches solving the same issue.
> 
> I promised Patrick that I would work on this issue, and I did.

Sorry, I'm forgetful sometimes :)

> Its running on our production servers, and I planned to release the
> patch today as it has proven stable on production.  I guess Thomas was
> just slightly faster than me ;-)
> 
> It was actually already released in the CPAN module IPTables::libiptc
> (ver.0.08 released 2008-06-16).
> 
> 
> We both use binary search, but with two slightly different approaches.
> 
> - My patch uses the existing data structure, and the existing
>   algorithm for binary searching.
> 
> - Thomas builds a new data structure and implements a new binary
>   search algorithm.
> 
> I must give Thomas that this binary search algo (taken from wikipedia)
> is much more compact than the existing one.
> 
> Guess I cannot judge what patch is the best, as I'm biased...

Me neither since you guys did all the work :)

Please work this out among yourselves. I think we should just pick
the faster one since both don't look very intrusive.