From: Andi Kleen <andi@firstfloor.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Venki Pallipadi <venkatesh.pallipadi@intel.com>,
Max Asbock <masbock@us.ibm.com>,
lkml <linux-kernel@vger.kernel.org>,
greg@kroah.com
Subject: Re: mce_64.c: mce_cpu_quirks being ignored
Date: Thu, 03 Jul 2008 15:22:13 +0200 [thread overview]
Message-ID: <486CD285.9050608@firstfloor.org> (raw)
In-Reply-To: <20080703130529.GA31372@elte.hu>
Ingo Molnar wrote:
> * Venki Pallipadi <venkatesh.pallipadi@intel.com> wrote:
>
>>> Venki, I did a patch for dynamic banks anyways, but haven't
>>> submitted it yet.
>> Yes. That particular quirk getting ignored was a bug. Below patch
>> fixes the bug, until we have the dynamic banks support.
>>
>> sysfs choice configuration should not have any issues with the earlier
>> patch as we look for NR_SYSFS_BANKS in do_machine_check().
>>
>> Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
>
> applied to tip/x86/mce - thanks Venki.
The dynamic banks patch is posted
http://marc.info/?l=linux-kernel&m=121493114604815&w=2
, but it turned out it requires
a sysfs infrastructure change for the auto-generated attributes.
I did that, but the patch is rather large
(http://marc.info/?l=linux-kernel&m=121493094104469&w=2)
Greg said he would queue the change, so dynamic banks could
be added (replacing Venki's two patches), but it would need
to be submitted after the infrastructure change.
-Andi
prev parent reply other threads:[~2008-07-03 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 20:44 mce_64.c: mce_cpu_quirks being ignored Max Asbock
2008-06-19 21:16 ` Andi Kleen
2008-06-25 0:12 ` Venki Pallipadi
2008-07-03 13:05 ` Ingo Molnar
2008-07-03 13:22 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486CD285.9050608@firstfloor.org \
--to=andi@firstfloor.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masbock@us.ibm.com \
--cc=mingo@elte.hu \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.