All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 5/5] [MIPS] Add an appropriate header into display.c
Date: Thu, 03 Jul 2008 18:28:31 +0300	[thread overview]
Message-ID: <486CF01F.9080808@movial.fi> (raw)
In-Reply-To: <20080703152338.GC11434@linux-mips.org>

Ralf Baechle wrote:
> On Wed, Jun 18, 2008 at 10:18:23AM +0300, Dmitri Vorobiev wrote:
> 
>> The following errors were caught by sparse:
>>
>> arch/mips/mips-boards/generic/display.c:30:6: warning: symbol
>> 'mips_display_message' was not declared. Should it be static?
>>
>> arch/mips/mips-boards/generic/display.c:58:6: warning: symbol
>> 'mips_scroll_message' was not declared. Should it be static?
>>
>> This patch includes the asm/mips-boards/prom.h header file into
>> arch/mips/mips-boards/generic/display.c. This adds the needed
>> function declarations, and the errors are gone.
>>
>> Compile-tested using defconfigs for Malta, Atlas and SEAD boards.
>> Runtime test was successfully performed by booting a Malta 4Kc
>> board up to the shell prompt.
>>
>> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
> 
> Queued for 2.6.27.  Thanks,

Ralf, thanks for picking up the series.

Dmitri

  reply	other threads:[~2008-07-03 15:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18  7:18 [PATCH 0/5] [MIPS] Another round of nitpicking Dmitri Vorobiev
2008-06-18  7:18 ` [PATCH 1/5] [MIPS] 8253: make the pit_clockevent variable static Dmitri Vorobiev
2008-07-03 15:21   ` Ralf Baechle
2008-06-18  7:18 ` [PATCH 2/5] [MIPS] Namespace clean-up in arch/mips/pci/pci.c Dmitri Vorobiev
2008-07-03 15:22   ` Ralf Baechle
2008-06-18  7:18 ` [PATCH 3/5] [MIPS] A few cleanups in malta_int.c Dmitri Vorobiev
2008-07-03 15:22   ` Ralf Baechle
2008-06-18  7:18 ` [PATCH 4/5] [MIPS] Make gcmp_probe() static Dmitri Vorobiev
2008-07-03 15:23   ` Ralf Baechle
2008-06-18  7:18 ` [PATCH 5/5] [MIPS] Add an appropriate header into display.c Dmitri Vorobiev
2008-07-03 15:23   ` Ralf Baechle
2008-07-03 15:28     ` Dmitri Vorobiev [this message]
2008-06-30  7:09 ` [PATCH 0/5] [MIPS] Another round of nitpicking Dmitri Vorobiev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=486CF01F.9080808@movial.fi \
    --to=dmitri.vorobiev@movial.fi \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.