All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [4844] Avoid compiler warning.
Date: Fri, 04 Jul 2008 08:05:37 +0200	[thread overview]
Message-ID: <486DBDB1.9070904@web.de> (raw)
In-Reply-To: <E1KEWTk-000782-7A@cvs.savannah.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

Thiemo Seufer wrote:
> Revision: 4844
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4844
> Author:   ths
> Date:     2008-07-03 21:36:35 +0000 (Thu, 03 Jul 2008)
> 
> Log Message:
> -----------
> Avoid compiler warning.
> 
> Modified Paths:
> --------------
>     trunk/cpu-all.h
> 
> Modified: trunk/cpu-all.h
> ===================================================================
> --- trunk/cpu-all.h	2008-07-03 19:55:47 UTC (rev 4843)
> +++ trunk/cpu-all.h	2008-07-03 21:36:35 UTC (rev 4844)
> @@ -667,7 +667,7 @@
>  
>  /* All direct uses of g2h and h2g need to go away for usermode softmmu.  */
>  #define g2h(x) ((void *)((unsigned long)(x) + GUEST_BASE))
> -#define h2g(x) ((target_ulong)(x - GUEST_BASE))
> +#define h2g(x) ((target_ulong)((unsigned long)(x) - GUEST_BASE))

Just to keep heads up: While this is OK in itself, the potential bug it
pointed out is still open, see

http://permalink.gmane.org/gmane.comp.emulators.qemu/26687

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

  reply	other threads:[~2008-07-04  9:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-03 21:36 [Qemu-devel] [4844] Avoid compiler warning Thiemo Seufer
2008-07-04  6:05 ` Jan Kiszka [this message]
2008-07-04  7:29 ` Laurent Desnogues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=486DBDB1.9070904@web.de \
    --to=jan.kiszka@web.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.