From: Jeff Garzik <jeff@garzik.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: netdev@vger.kernel.org, themann@de.ibm.com
Subject: Re: [PATCH] ehea: Access iph->tot_len with correct endianness
Date: Fri, 04 Jul 2008 08:15:57 -0400 [thread overview]
Message-ID: <486E147D.4090105@garzik.org> (raw)
In-Reply-To: <ada7ic5ed26.fsf@cisco.com>
Roland Dreier wrote:
> iph->tot_len is stored in network byte order, so access it using
> ntohs(). This doesn't have any real world impact on ehea, since ehea
> only exists for big-endian platfroms (at the moment at least) but fixing
> this gets rid of a sparse warning and avoids having a bad example in the
> tree.
>
> Signed-off-by: Roland Dreier <rolandd@cisco.com>
> ---
> drivers/net/ehea/ehea_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
applied this and pasemi_mac patch to 2.6.26.
prev parent reply other threads:[~2008-07-04 12:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 17:20 [PATCH] ehea: Access iph->tot_len with correct endianness Roland Dreier
2008-07-02 14:45 ` Thomas Klein
2008-07-04 12:15 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486E147D.4090105@garzik.org \
--to=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=themann@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.