From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.dvmed.net (srv5.dvmed.net [207.36.208.214]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3D08BDDED1 for ; Fri, 4 Jul 2008 22:17:37 +1000 (EST) Message-ID: <486E14DA.6070104@garzik.org> Date: Fri, 04 Jul 2008 08:17:30 -0400 From: Jeff Garzik MIME-Version: 1.0 To: Stefan Roese Subject: Re: [PATCH v3] ibm_newemac: Fixes kernel crashes when speed of cable connected changes References: <1214902685-10489-1-git-send-email-sr@denx.de> In-Reply-To: <1214902685-10489-1-git-send-email-sr@denx.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linuxppc-dev@ozlabs.org, Sathya Narayanan , netdev@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Stefan Roese wrote: > From: Sathya Narayanan > > The descriptor pointers were not initialized to NIL values, so it was > poiniting to some random addresses which was completely invalid. This > fix takes care of initializing the descriptor to NIL values and clearing > the valid descriptors on clean ring operation. > > Signed-off-by: Sathya Narayanan > Signed-off-by: Stefan Roese > --- > drivers/net/ibm_newemac/core.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c > index 5d2108c..ca63fa0 100644 > --- a/drivers/net/ibm_newemac/core.c > +++ b/drivers/net/ibm_newemac/core.c > @@ -2719,6 +2719,8 @@ static int __devinit emac_probe(struct of_device *ofdev, > /* Clean rings */ > memset(dev->tx_desc, 0, NUM_TX_BUFF * sizeof(struct mal_descriptor)); > memset(dev->rx_desc, 0, NUM_RX_BUFF * sizeof(struct mal_descriptor)); > + memset(dev->tx_skb, 0, NUM_TX_BUFF * sizeof(struct sk_buff *)); > + memset(dev->rx_skb, 0, NUM_RX_BUFF * sizeof(struct sk_buff *)); > applied to 2.6.26 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH v3] ibm_newemac: Fixes kernel crashes when speed of cable connected changes Date: Fri, 04 Jul 2008 08:17:30 -0400 Message-ID: <486E14DA.6070104@garzik.org> References: <1214902685-10489-1-git-send-email-sr@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org, benh@kernel.crashing.org, Sathya Narayanan To: Stefan Roese Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:48150 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753001AbYGDMRg (ORCPT ); Fri, 4 Jul 2008 08:17:36 -0400 In-Reply-To: <1214902685-10489-1-git-send-email-sr@denx.de> Sender: netdev-owner@vger.kernel.org List-ID: Stefan Roese wrote: > From: Sathya Narayanan > > The descriptor pointers were not initialized to NIL values, so it was > poiniting to some random addresses which was completely invalid. This > fix takes care of initializing the descriptor to NIL values and clearing > the valid descriptors on clean ring operation. > > Signed-off-by: Sathya Narayanan > Signed-off-by: Stefan Roese > --- > drivers/net/ibm_newemac/core.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c > index 5d2108c..ca63fa0 100644 > --- a/drivers/net/ibm_newemac/core.c > +++ b/drivers/net/ibm_newemac/core.c > @@ -2719,6 +2719,8 @@ static int __devinit emac_probe(struct of_device *ofdev, > /* Clean rings */ > memset(dev->tx_desc, 0, NUM_TX_BUFF * sizeof(struct mal_descriptor)); > memset(dev->rx_desc, 0, NUM_RX_BUFF * sizeof(struct mal_descriptor)); > + memset(dev->tx_skb, 0, NUM_TX_BUFF * sizeof(struct sk_buff *)); > + memset(dev->rx_skb, 0, NUM_RX_BUFF * sizeof(struct sk_buff *)); > applied to 2.6.26