Re: [PATCH] sata_mv: safer logic for limit_warnings

[Jeff Garzik <jgarzik@pobox.com>]

Mark Lord wrote:
> There is a miniscule chance that two separate host controllers
> might be in sata_mv at the same time and manage to decrement
> the static limit_warnings variable below zero.
> 
> Fix the comparison to deal with it.
> 
> Signed-off-by: Mark Lord <mlord@pobox.com>
> ---
> 
> (blush) How did I miss that ???
> 
> --- old/drivers/ata/sata_mv.c    2008-06-17 19:22:15.000000000 -0400
> +++ linux//drivers/ata/sata_mv.c    2008-06-18 21:52:19.000000000 -0400
> @@ -1607,7 +1607,7 @@
>          * Much of the time, this could just work regardless.
>          * So for now, just log the incident, and allow the attempt.
>          */
> -        if (limit_warnings && (qc->nbytes / qc->sect_size) > 1) {
> +        if (limit_warnings > 0 && (qc->nbytes / qc->sect_size) > 1) {
>             --limit_warnings;
>             ata_link_printk(qc->dev->link, KERN_WARNING, DRV_NAME

applied.  sorry, this got buried, should have gone in sooner.