From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KErIA-0000o5-U3 for mharc-grub-devel@gnu.org; Fri, 04 Jul 2008 15:50:02 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KErI9-0000mf-B2 for grub-devel@gnu.org; Fri, 04 Jul 2008 15:50:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KErI7-0000ly-Gu for grub-devel@gnu.org; Fri, 04 Jul 2008 15:50:00 -0400 Received: from [199.232.76.173] (port=59654 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KErI7-0000ls-96 for grub-devel@gnu.org; Fri, 04 Jul 2008 15:49:59 -0400 Received: from mta-out.inet.fi ([195.156.147.13]:48008 helo=kirsi1.rokki.sonera.fi) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KErI6-0001dC-WC for grub-devel@gnu.org; Fri, 04 Jul 2008 15:49:59 -0400 Received: from [127.0.0.1] (88.193.32.97) by kirsi1.rokki.sonera.fi (8.5.014) id 483E837C0198200F for grub-devel@gnu.org; Fri, 4 Jul 2008 22:49:55 +0300 Message-ID: <486E7EE7.6080509@nic.fi> Date: Fri, 04 Jul 2008 22:49:59 +0300 From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) MIME-Version: 1.0 To: The development of GRUB 2 References: <20080623075438.5861e6d1@gibibit.com> <878wwi6bqy.fsf@xs4all.nl> <20080704112801.470827ea@gibibit.com> In-Reply-To: <20080704112801.470827ea@gibibit.com> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: Quoted-Printable X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [RFC] TSC patch v2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jul 2008 19:50:01 -0000 Hi Colin, Colin D Bennett wrote: > Here is an updated version of the TSC patch. >=20 > I addressed the issues in your comments with the exception of > supporting x86 CPUs that don't have a TSC (386 and 486). >=20 > I eliminated the grub_time_init() function and the call to it in > grub_main() in favor of having grub_machine_init() simply call > grub_tsc_calibrate(). The i386-pc and i386-efi platforms use the TSC. Please still use grub_time_init(). Detect TSC, if it is there calibrate=20 and adapt for it. If it is not there, use RTC. grub_time_init() is just more clearer term than tsc. At least for people=20 that are not familiar with it. in grub_time_init() you can have anything=20 then. And people that are not interested on time stuff do not need to=20 bother their heads about it. Also modifying logic afterwards do not=20 change other parts and it will be less error prone. Thanks, Vesa J=E4=E4skel=E4inen