From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Head Subject: Blktap extended device number support bug Date: Fri, 04 Jul 2008 23:20:32 -0700 Message-ID: <486F12B0.3070409@cs.ubc.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, In xenlinux revision 582, domid_translate_t is redefined from containing a pair of unsigned shorts to contain an unsigned short and a u32. Unfortunately, down on lines 772 and 773 of drivers/xen/blktap/blktap.c, a domid_translate_t is built out of an unsigned long. This of course doesn't work, because domid_translate_t is now 48 bits long while unsigned long is only 32. I suggest passing a pointer into the ioctl and doing a proper user-to-kernel copy. Also, the userspace tools in xen-3.2-testing also need modifying as they have their own copy of the struct declaration (and will in any case need updating to pass a pointer instead of the struct packed into an unsigned long). Chris -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: GnuPT 2.7.2 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkhvEq8ACgkQiD2svb/jCb7rOQCfUhWy+k+oJfGnu6tgJKVAdH4m gccAn0AUoEE5MNJ6BLSVmytt5tHkIXHV =VvIn -----END PGP SIGNATURE-----