All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Linux Netdev List <netdev@vger.kernel.org>
Cc: Jeff Garzik <jeff@garzik.org>, ionut@cs.columbia.edu
Subject: [PATCH 05/06]: starfire: don't truncate VLAN TCI with VLAN stripping
Date: Mon, 07 Jul 2008 00:48:18 +0200	[thread overview]
Message-ID: <48714BB2.9020904@trash.net> (raw)
In-Reply-To: <487148E0.5040407@trash.net>

[-- Attachment #1: Type: text/plain, Size: 2 bytes --]




[-- Attachment #2: 05.diff --]
[-- Type: text/x-diff, Size: 1255 bytes --]

starfire: don't truncate VLAN TCI with VLAN stripping

The vlan_hwaccel_{rx,receive_skb} functions expect the full TCI field
for priority mappings, don't truncate the upper 4 bits.

Signed-off-by: Patrick McHardy <kaber@trash.net>

---
commit c8695f4c66c53182b2b6dc8a848d07e0208edd5d
tree 520848e31ff58269e8486a3116387a21e67f3202
parent 92c22c36d1e18c443bbbe0097c005ebc94e82a4f
author Patrick McHardy <kaber@trash.net> Mon, 07 Jul 2008 00:25:14 +0200
committer Patrick McHardy <kaber@trash.net> Mon, 07 Jul 2008 00:25:14 +0200

 drivers/net/starfire.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/starfire.c b/drivers/net/starfire.c
index 7b7b171..2038f38 100644
--- a/drivers/net/starfire.c
+++ b/drivers/net/starfire.c
@@ -1510,7 +1510,7 @@ static int __netdev_rx(struct net_device *dev, int *quota)
 			if (debug > 4)
 				printk(KERN_DEBUG "  netdev_rx() vlanid = %d\n", le16_to_cpu(desc->vlanid));
 			/* vlan_netdev_receive_skb() expects a packet with the VLAN tag stripped out */
-			vlan_netdev_receive_skb(skb, np->vlgrp, le16_to_cpu(desc->vlanid) & VLAN_VID_MASK);
+			vlan_netdev_receive_skb(skb, np->vlgrp, le16_to_cpu(desc->vlanid));
 		} else
 #endif /* VLAN_SUPPORT */
 			netdev_receive_skb(skb);


  parent reply	other threads:[~2008-07-06 22:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <487148E0.5040407@trash.net>
2008-07-06 22:48 ` [PATCH 01/06]: e1000: don't truncate VLAN TCI with VLAN stripping Patrick McHardy
2008-07-06 22:48 ` [PATCH 02/06]: e1000e: " Patrick McHardy
2008-07-06 22:48 ` [PATCH 03/06]: igb: " Patrick McHardy
2008-07-06 22:48 ` [PATCH 04/06]: ixgb: " Patrick McHardy
2008-07-06 22:48 ` Patrick McHardy [this message]
2008-07-06 22:48 ` [PATCH 06/06]: tehuti: " Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48714BB2.9020904@trash.net \
    --to=kaber@trash.net \
    --cc=ionut@cs.columbia.edu \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.