All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Patrick McHardy <kaber@trash.net>, David Miller <davem@davemloft.net>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
	jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,
	PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>,
	john.ronciak@intel.com, ionut@cs.columbia.edu,
	baum@tehutinetworks.net, andy@greyhouse.net
Subject: Re: [PATCH 00/06]: VLAN TCI truncation fixes
Date: Sun, 06 Jul 2008 21:51:26 -0400	[thread overview]
Message-ID: <4871769E.2020305@garzik.org> (raw)
In-Reply-To: <48714BA3.3080102@trash.net>

Patrick McHardy wrote:
> These patches fix all drivers supporting VLAN header stripping to
> pass the complete VLAN TCI to vlan_hwaccel_{rx,receive_skb} instead
> of just the VID. The upper three bits contain the priority and are
> used for ingress priority mappings.
> 
> The e1000 patch is runtime tested, the others only compile tested.
> 
> 
> drivers/net/e1000/e1000_main.c |   12 ++++--------
> drivers/net/e1000e/netdev.c    |    3 +--
> drivers/net/igb/igb_main.c     |    3 +--
> drivers/net/ixgb/ixgb_main.c   |    6 ++----
> drivers/net/starfire.c         |    2 +-
> drivers/net/tehuti.c           |    2 +-
> drivers/net/tehuti.h           |    1 +
> 7 files changed, 11 insertions(+), 18 deletions(-)
> 
> Patrick McHardy (6):
>      e1000: don't truncate VLAN TCI with VLAN stripping
>      e1000e: don't truncate VLAN TCI with VLAN stripping
>      igb: don't truncate VLAN TCI with VLAN stripping
>      ixgb: don't truncate VLAN TCI with VLAN stripping
>      starfire: don't truncate VLAN TCI with VLAN stripping
>      tehuti: don't truncate VLAN TCI with VLAN stripping

Acked-by: Jeff Garzik <jgarzik@redhat.com>

Though I would suggest combining all these patches into a single patch, 
since they constitute a single logical change, and each change is 
self-contained and small.

	Jeff




  reply	other threads:[~2008-07-07  1:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-06 22:48 [PATCH 00/06]: VLAN TCI truncation fixes Patrick McHardy
2008-07-07  1:51 ` Jeff Garzik [this message]
2008-07-07  2:11   ` Patrick McHardy
2008-07-07  3:49     ` David Miller
2008-07-07 21:16       ` Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4871769E.2020305@garzik.org \
    --to=jeff@garzik.org \
    --cc=andy@greyhouse.net \
    --cc=baum@tehutinetworks.net \
    --cc=davem@davemloft.net \
    --cc=ionut@cs.columbia.edu \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.