Re: [PATCH] ltp controllers: block device i/o bandwidth controller testcase

[Andrea Righi <righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Subrata Modak wrote:
> Thanks Andrea for contributing these tests to LTP. I will take some time
> before testing this and coming back to you. Give me some time. Meanwhile
> it would be great if Balbir/Dhaval/others can provide some review
> comments as well.
> 
> Regards--
> Subrata
> 
> On Mon, 2008-07-07 at 12:05 +0200, Andrea Righi wrote:
>> Add the block device I/O bandwidth controller (io-throttle) testcase.
>>
>> See testcase documentation for design and implementation details.
>> See also: http://lkml.org/lkml/2008/7/4/143
>>
>> Signed-off-by: Andrea Righi <righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
...
>> diff --exclude CVS -urpN ltp/testcases/kernel/controllers.orig/Makefile ltp/testcases/kernel/controllers/Makefile
>> --- ltp/testcases/kernel/controllers.orig/Makefile	2008-04-30 09:19:29.000000000 +0200
>> +++ ltp/testcases/kernel/controllers/Makefile	2008-07-07 11:43:07.000000000 +0200
>> @@ -1,6 +1,7 @@
>>  SUBDIRS = libcontrollers cpuctl memctl

yep! it seems I missed the target to build the whole thing.

Fix missing build targer for block device I/O bandwidth controller.
Patch to be applied on top of the previous one.

Both patches are also available here:
http://download.systemimager.org/~arighi/ltp/

Signed-off-by: Andrea Righi <righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
--- ltp/testcases/kernel/controllers/Makefile.orig	2008-07-07 15:21:42.000000000 +0200
+++ ltp/testcases/kernel/controllers/Makefile	2008-07-07 12:25:50.000000000 +0200
@@ -1,4 +1,4 @@
-SUBDIRS = libcontrollers cpuctl memctl
+SUBDIRS = libcontrollers cpuctl memctl io-throttle
 CHECK_CPUCTL = $(shell grep -w cpu /proc/cgroups|cut -f1)
 CHECK_MEMCTL = $(shell grep -w memory /proc/cgroups|cut -f1)
 CHECK_BLOCKIOCTL= $(shell grep -w blockio /proc/cgroups|cut -f1)

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08