From: Valentine Barshak <vbarshak@ru.mvista.com>
To: Grant Erickson <gerickson@nuovations.com>
Cc: linuxppc-dev@ozlabs.org, sr@denx.de
Subject: Re: [PATCH v5] ibm_newemac: Parameterize EMAC Multicast Match Handling
Date: Mon, 07 Jul 2008 23:50:12 +0400 [thread overview]
Message-ID: <48727374.1010304@ru.mvista.com> (raw)
In-Reply-To: <1215387012-6464-1-git-send-email-gerickson@nuovations.com>
Grant Erickson wrote:
<snip>
> index 48c9a6e..799592d 100644
> --- a/arch/powerpc/boot/dts/kilauea.dts
> +++ b/arch/powerpc/boot/dts/kilauea.dts
> @@ -205,7 +205,7 @@
> EMAC0: ethernet@ef600900 {
> linux,network-index = <0>;
> device_type = "network";
> - compatible = "ibm,emac-405ex", "ibm,emac4";
> + compatible = "ibm,emac-405ex", "ibm,emac4sync";
> interrupt-parent = <&EMAC0>;
> interrupts = <0 1>;
> #interrupt-cells = <1>;
> @@ -213,7 +213,7 @@
> #size-cells = <0>;
> interrupt-map = </*Status*/ 0 &UIC0 18 4
> /*Wake*/ 1 &UIC1 1d 4>;
> - reg = <ef600900 70>;
> + reg = <ef600900 c4>;
> local-mac-address = [000000000000]; /* Filled in by U-Boot */
> mal-device = <&MAL0>;
> mal-tx-channel = <0>;
> @@ -233,7 +233,7 @@
> EMAC1: ethernet@ef600a00 {
> linux,network-index = <1>;
> device_type = "network";
> - compatible = "ibm,emac-405ex", "ibm,emac4";
> + compatible = "ibm,emac-405ex", "ibm,emac4sync";
> interrupt-parent = <&EMAC1>;
> interrupts = <0 1>;
> #interrupt-cells = <1>;
> @@ -241,7 +241,7 @@
> #size-cells = <0>;
> interrupt-map = </*Status*/ 0 &UIC0 19 4
> /*Wake*/ 1 &UIC1 1f 4>;
> - reg = <ef600a00 70>;
> + reg = <ef600900 c4>;
Should be reg = <ef600a00 c4>
<snip>
> --- a/arch/powerpc/boot/dts/makalu.dts
> +++ b/arch/powerpc/boot/dts/makalu.dts
> @@ -205,7 +205,7 @@
> EMAC0: ethernet@ef600900 {
> linux,network-index = <0>;
> device_type = "network";
> - compatible = "ibm,emac-405ex", "ibm,emac4";
> + compatible = "ibm,emac-405ex", "ibm,emac4sync";
> interrupt-parent = <&EMAC0>;
> interrupts = <0 1>;
> #interrupt-cells = <1>;
> @@ -213,7 +213,7 @@
> #size-cells = <0>;
> interrupt-map = </*Status*/ 0 &UIC0 18 4
> /*Wake*/ 1 &UIC1 1d 4>;
> - reg = <ef600900 70>;
> + reg = <ef600900 c4>;
> local-mac-address = [000000000000]; /* Filled in by U-Boot */
> mal-device = <&MAL0>;
> mal-tx-channel = <0>;
> @@ -233,7 +233,7 @@
> EMAC1: ethernet@ef600a00 {
> linux,network-index = <1>;
> device_type = "network";
> - compatible = "ibm,emac-405ex", "ibm,emac4";
> + compatible = "ibm,emac-405ex", "ibm,emac4sync";
> interrupt-parent = <&EMAC1>;
> interrupts = <0 1>;
> #interrupt-cells = <1>;
> @@ -241,7 +241,7 @@
> #size-cells = <0>;
> interrupt-map = </*Status*/ 0 &UIC0 19 4
> /*Wake*/ 1 &UIC1 1f 4>;
> - reg = <ef600a00 70>;
> + reg = <ef600900 c4>;
Should be reg = <ef600a00 c4>
Thanks,
Valentine.
next prev parent reply other threads:[~2008-07-07 19:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 0:08 [PATCH v2] Parameterize EMAC Multicast Match Handling Grant Erickson
2008-07-01 5:26 ` Grant Erickson
2008-07-01 6:14 ` Benjamin Herrenschmidt
2008-07-01 6:37 ` Stefan Roese
2008-07-01 18:13 ` Grant Erickson
2008-07-01 19:42 ` Stefan Roese
2008-07-01 23:52 ` Benjamin Herrenschmidt
2008-07-05 9:18 ` [PATCH v3] ibm_newemac: " Grant Erickson
2008-07-05 22:45 ` Benjamin Herrenschmidt
2008-07-06 0:15 ` [PATCH v4] " Grant Erickson
2008-07-06 0:31 ` Benjamin Herrenschmidt
2008-07-06 9:43 ` Stefan Roese
2008-07-06 23:30 ` [PATCH v5] " Grant Erickson
2008-07-07 5:58 ` Stefan Roese
2008-07-07 6:00 ` Benjamin Herrenschmidt
2008-07-07 6:29 ` Stefan Roese
2008-07-07 6:43 ` Benjamin Herrenschmidt
2008-07-07 6:18 ` Benjamin Herrenschmidt
2008-07-07 13:59 ` Jeff Garzik
2008-07-07 19:50 ` Valentine Barshak [this message]
2008-07-07 22:02 ` Grant Erickson
2008-07-07 22:03 ` [PATCH v6] " Grant Erickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48727374.1010304@ru.mvista.com \
--to=vbarshak@ru.mvista.com \
--cc=gerickson@nuovations.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.