From: David Hildenbrand <david@redhat.com>
To: Hugh Dickins <hughd@google.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>,
Nhat Pham <nphamcs@gmail.com>, Yang Shi <shy828301@gmail.com>,
Zi Yan <ziy@nvidia.com>, Barry Song <baohua@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH hotfix] mm: fix crashes from deferred split racing folio migration
Date: Sun, 7 Jul 2024 10:28:51 +0200 [thread overview]
Message-ID: <48727db1-aac8-40d2-be20-9fd7777af62a@redhat.com> (raw)
In-Reply-To: <68feee73-050e-8e98-7a3a-abf78738d92c@google.com>
> [I guess this is the wrong place to say so, but folio_undo_large_rmappable()
> is a dreadful name: it completely obscures what the function actually does,
> and gives the false impression that the folio would be !large_rmappable
> afterwards. I hope that one day the name gets changed to something like
> folio_unqueue_deferred_split() or folio_cancel_deferred_split().]
Fully agreed, that is absolutely confusing. (and I thought for a second
that the folio would be !large_rmappable afterwards!)
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2024-07-07 8:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 7:40 [PATCH hotfix] mm: fix crashes from deferred split racing folio migration Hugh Dickins
2024-07-02 9:25 ` Baolin Wang
2024-07-02 16:15 ` Hugh Dickins
2024-07-03 1:51 ` Baolin Wang
2024-07-03 2:13 ` Andrew Morton
2024-07-03 14:30 ` Zi Yan
2024-07-03 16:21 ` David Hildenbrand
2024-07-03 16:22 ` Zi Yan
2024-07-04 2:35 ` Andrew Morton
2024-07-04 3:21 ` Hugh Dickins
2024-07-04 3:28 ` Andrew Morton
2024-07-04 6:12 ` Kefeng Wang
2024-07-06 21:29 ` Hugh Dickins
2024-07-07 2:11 ` Andrew Morton
2024-07-07 3:07 ` Kefeng Wang
2024-07-07 8:28 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48727db1-aac8-40d2-be20-9fd7777af62a@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=shy828301@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.