Re: [PATCH] [0/9] Use 64bit x86 machine check code for 32bit too

[Andi Kleen <andi@firstfloor.org>]

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

H. Peter Anvin wrote:
> Andi Kleen wrote:
>> This patchkit uses the 64bit machine check code which is better in many
>> ways on 32bit x86 too. This is also the basis for some future machine
>> check work.
> 
> Hi Andi,
> 
> I tried applying your patch kit to -tip, but I'm getting build failures
> on i386; gcc-4.1.1-51.fc5.x86_64 with attached configuration.

Thanks for testing.

Your config seems to for some reason not do an implicit asm/apic.h
that the file relied on.

With this additional patch applied before the final unification
your config builds.

Also fixed the strtoull warnings.

I'm sending a new patch series.

-Andi




[-- Attachment #2: include --]
[-- Type: text/plain, Size: 576 bytes --]

Add missing includes in mce_intel_64.c

In some i386 configurations these are not implicitely included.

Signed-off-by: Andi Kleen <ak@linux.intel.com>

Index: linux/arch/x86/kernel/cpu/mcheck/mce_intel_64.c
===================================================================
--- linux.orig/arch/x86/kernel/cpu/mcheck/mce_intel_64.c
+++ linux/arch/x86/kernel/cpu/mcheck/mce_intel_64.c
@@ -12,6 +12,8 @@
 #include <asm/hw_irq.h>
 #include <asm/idle.h>
 #include <asm/therm_throt.h>
+#include <asm/apic.h>
+#include <asm/pda.h>
 
 asmlinkage void smp_thermal_interrupt(void)
 {