All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] convert xfs to use ERR_CAST
Date: Mon, 07 Jul 2008 21:55:33 -0500	[thread overview]
Message-ID: <4872D725.5070306@sandeen.net> (raw)
In-Reply-To: <480FA737.5030001@sandeen.net>

Eric Sandeen wrote:
> Looks like somehow xfs got missed in the conversion that
> took place in e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f,
> "Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p) <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f>"
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---

ping.

This one's really, really, really easy :)

-Eric

> ndex: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_export.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_export.c
> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_export.c
> @@ -167,7 +167,7 @@ xfs_fs_fh_to_dentry(struct super_block *
>  	if (!inode)
>  		return NULL;
>  	if (IS_ERR(inode))
> -		return ERR_PTR(PTR_ERR(inode));
> +		return ERR_CAST(inode);
>  	result = d_alloc_anon(inode);
>  	if (!result) {
>  		iput(inode);
> @@ -198,7 +198,7 @@ xfs_fs_fh_to_parent(struct super_block *
>  	if (!inode)
>  		return NULL;
>  	if (IS_ERR(inode))
> -		return ERR_PTR(PTR_ERR(inode));
> +		return ERR_CAST(inode);
>  	result = d_alloc_anon(inode);
>  	if (!result) {
>  		iput(inode);
> 
> 
> 

  parent reply	other threads:[~2008-07-08  2:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-23 21:16 [PATCH] convert xfs to use ERR_CAST Eric Sandeen
2008-04-25  8:59 ` Christoph Hellwig
2008-04-25  9:55 ` David Howells
2008-07-08  2:55 ` Eric Sandeen [this message]
2008-07-24  8:21 ` Niv Sardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4872D725.5070306@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.