From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wayne Gong Subject: WinPv driver 64bit patch Date: Tue, 08 Jul 2008 13:10:16 +0800 Message-ID: <4872F6B8.8050908@oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------050507050408040005080402" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "xen-devel@lists.xensource.com" , James Harper List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------050507050408040005080402 Content-Type: multipart/alternative; boundary="------------060300080308040808050303" --------------060300080308040808050303 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi James, This patch can help WinPv driver work fine on Windows 2003 x64 version. Please review. Best regards Wayne --------------060300080308040808050303 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi James,

This patch can help WinPv driver work fine on Windows 2003 x64 version.
Please review.

Best regards
Wayne
 --------------060300080308040808050303-- --------------050507050408040005080402 Content-Type: text/plain; name="64bit.patch" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="64bit.patch" IyBIRyBjaGFuZ2VzZXQgcGF0Y2gKIyBVc2VyIFdheW5lIEdvbmcgPHdheW5lLmdvbmdAb3Jh Y2xlLmNvbT4KIyBEYXRlIDEyMTU0OTM2MzIgLTI4ODAwCiMgTm9kZSBJRCBkYmFmOGYxNTZm M2Y0Y2Q2ZjZhY2M1YTEwY2RmMWQyODI4MDlkMWZmCiMgUGFyZW50ICBiZmM2ZTFmOTliNGZj YmQ0YTVkMjBiMTM5MmQyOGJlNjZmZDMxMGZjCkxldCB3aW5wdiB3b3JrIGZvciB3aW4yazNf eDY0LgoKZGlmZiAtciBiZmM2ZTFmOTliNGYgLXIgZGJhZjhmMTU2ZjNmIHhlbmhpZGUveGVu aGlkZS5jCi0tLSBhL3hlbmhpZGUveGVuaGlkZS5jCVR1ZSBKdWwgMDggMTM6MDQ6NDEgMjAw OCArMDgwMAorKysgYi94ZW5oaWRlL3hlbmhpZGUuYwlUdWUgSnVsIDA4IDEzOjA3OjEyIDIw MDggKzA4MDAKQEAgLTE3MSwxMiArMTcxLDEyIEBACiBYZW5IaWRlX0lkU3VmZml4TWF0Y2hl cyhQREVWSUNFX09CSkVDVCBwZG8sIFBXQ0hBUiBtYXRjaGluZ19pZCkNCiB7DQogICBOVFNU QVRVUyBzdGF0dXM7DQotICBVTE9ORyByZW1haW5pbmc7DQotICBVTE9ORyBzdHJpbmdfbGVu Z3RoOw0KKyAgVUxPTkcgY21wTGVuID0gMDsNCiAgIFdDSEFSIGlkc1s1MTJdOw0KICAgUFdD SEFSIHB0cjsNCiAgIFVMT05HIGlkc19sZW5ndGg7DQogICBpbnQgaTsNCisgIHNpemVfdCBq ID0gMDsNCiAgIA0KICAgZm9yIChpID0gMDsgaSA8IDI7IGkrKykNCiAgIHsNCkBAIC0xOTAs MjAgKzE5MCwyOSBAQAogICAgICAgLy9LZFByaW50KChfX0RSSVZFUl9OQU1FICIgICAgIGkg PSAlZCwgc3RhdHVzID0gJXgsIGlkc19sZW5ndGggPSAlZFxuIiwgaSwgc3RhdHVzLCBpZHNf bGVuZ3RoKSk7DQogICAgICAgY29udGludWU7DQogICAgIH0NCi0gICAgDQotICAgIHJlbWFp bmluZyA9IGlkc19sZW5ndGggLyAyOw0KLSAgICBmb3IgKHB0ciA9IGlkczsgKnB0ciAhPSAw OyBwdHIgKz0gc3RyaW5nX2xlbmd0aCArIDEpDQorICAgIHB0ciA9IGlkczsNCisgICAgZm9y IChqID0gMDsgaiA8IDUxMiAtIDM7IGorKykNCiAgICAgew0KLSAgICAgIFJ0bFN0cmluZ0Nj aExlbmd0aFcocHRyLCByZW1haW5pbmcsIChzaXplX3QgKikmc3RyaW5nX2xlbmd0aCk7DQot ICAgICAgcmVtYWluaW5nIC09IHN0cmluZ19sZW5ndGggLSAxOw0KLSAgICAgIGlmIChzdHJp bmdfbGVuZ3RoID49IHdjc2xlbihtYXRjaGluZ19pZCkpDQorICAgICAgaWYgKGlkc1tqXSA9 PSBMJ1YnICYmIGlkc1tqKzFdID09IEwnRScgJiYgaWRzW2orMl0gPT0gTCdOJykNCisgICAg ICB7ICANCisgICAgICAgIHB0ciA9IGlkcyArIGo7DQorICAgICAgICBjbXBMZW4gPSAxNzsg Ly8gIlZFTl8xMEVDJkRFVl84MTM5Ig0KKyAgICAgICAgYnJlYWs7DQorICAgICAgfQ0KKyAg ICAgIGlmIChpZHNbal0gPT0gTCdQJyAmJiBpZHNbaisxXSA9PSBMJ04nICYmIGlkc1tqKzJd ID09IEwnUCcpDQogICAgICAgew0KLSAgICAgICAgcHRyICs9IHN0cmluZ19sZW5ndGggLSB3 Y3NsZW4obWF0Y2hpbmdfaWQpOw0KLSAgICAgICAgc3RyaW5nX2xlbmd0aCAtPSAoVUxPTkcp d2NzbGVuKG1hdGNoaW5nX2lkKTsNCisgICAgICAgIHB0ciA9IGlkcyArIGo7DQorICAgICAg ICBjbXBMZW4gPSA3OyAvLyAiUE5QMEEwMyINCisgICAgICAgIGJyZWFrOw0KICAgICAgIH0N Ci0gICAgICAvL0tkUHJpbnQoKF9fRFJJVkVSX05BTUUgIiAgICAgQ29tcGFyaW5nICclUycg YW5kICclUydcbiIsIHB0ciwgbWF0Y2hpbmdfaWQpKTsNCi0gICAgICBpZiAod2NzY21wKHB0 ciwgbWF0Y2hpbmdfaWQpID09IDApDQotICAgICAgIHJldHVybiBUUlVFOw0KKyAgICB9DQor ICAgIGlmIChqID09IDUxMiAtIDMpDQorICAgICAgYnJlYWs7DQorICAgIC8vS2RQcmludCgo X19EUklWRVJfTkFNRSAiICAgICBDb21wYXJpbmcgJyVTJyBhbmQgJyVTJ1xuIiwgcHRyLCBt YXRjaGluZ19pZCkpOw0KKyAgICBpZiAod2NzbmNtcChwdHIsIG1hdGNoaW5nX2lkLCBjbXBM ZW4pID09IDApDQorICAgIHsNCisgICAgICAvL0tkUHJpbnQoKF9fRFJJVkVSX05BTUUgIiAg ICAgTWF0Y2hlZFxuIikpOw0KKyAgICAgIHJldHVybiBUUlVFOw0KICAgICB9DQogICB9DQog ICAvL0tkUHJpbnQoKF9fRFJJVkVSX05BTUUgIiAgICAgTm8gbWF0Y2hcbiIpKTsgIA0K --------------050507050408040005080402 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------050507050408040005080402-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: "James Harper" Subject: RE: WinPv driver 64bit patch Date: Tue, 8 Jul 2008 15:13:20 +1000 Message-ID: References: <4872F6B8.8050908@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: Content-class: urn:content-classes:message In-Reply-To: <4872F6B8.8050908@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Wayne Gong , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>From a quick glance of your patch, I can't seem to figure out why you have made the changes you have made... can you offer a quick explanation? Thanks James > -----Original Message----- > From: Wayne Gong [mailto:wayne.gong@oracle.com] > Sent: Tuesday, 8 July 2008 15:10 > To: xen-devel@lists.xensource.com; James Harper > Subject: WinPv driver 64bit patch >=20 > Hi James, >=20 > This patch can help WinPv driver work fine on Windows 2003 x64 version. > Please review. >=20 > Best regards > Wayne From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wayne Gong Subject: Re: RE: WinPv driver 64bit patch Date: Tue, 08 Jul 2008 13:22:10 +0800 Message-ID: <4872F982.1080206@oracle.com> References: <4872F6B8.8050908@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org James Harper wrote: > >From a quick glance of your patch, I can't seem to figure out why you > have made the changes you have made... can you offer a quick > explanation? > In my 64bit environment as sent to you yesterday, xenhide driver will enter a dead loop in function XenHide_IdSuffixMatches and windows cannot boot up correctly. Wayne From mboxrd@z Thu Jan 1 00:00:00 1970 From: "James Harper" Subject: RE: WinPv driver 64bit patch Date: Wed, 9 Jul 2008 10:44:47 +1000 Message-ID: References: <4872F6B8.8050908@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: Content-class: urn:content-classes:message In-Reply-To: <4872F6B8.8050908@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Wayne Gong , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Wayne, I've taken an alternate approach with this - the original code had 2 bugs: . I had foolishly cast a pointer to size_t (64 bits on amd64) to a PULONG, so 'i' was getting overwritten with 0 and the loop would never finish. . I had mucked up some addition and subtraction Btw, I haven't actually tested on x64 in a while, I am finding the following problems: 1. xennet won't install, when I try to install it says 'The parameter value is incorrect' 2. xenvbd appears to install okay, but there are some odd messages in the logs 3. xenstub won't load, I get "xenstub.sys has been blocked from loading due to incompatibility with this system." Any ideas? James > -----Original Message----- > From: Wayne Gong [mailto:wayne.gong@oracle.com] > Sent: Tuesday, 8 July 2008 15:10 > To: xen-devel@lists.xensource.com; James Harper > Subject: WinPv driver 64bit patch >=20 > Hi James, >=20 > This patch can help WinPv driver work fine on Windows 2003 x64 version. > Please review. >=20 > Best regards > Wayne From mboxrd@z Thu Jan 1 00:00:00 1970 From: "James Harper" Subject: RE: RE: WinPv driver 64bit patch Date: Wed, 9 Jul 2008 11:14:38 +1000 Message-ID: References: <4872F6B8.8050908@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: Content-class: urn:content-classes:message In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: James Harper , Wayne Gong , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org > Btw, I haven't actually tested on x64 in a while, I am finding the > following problems: >=20 > 1. xennet won't install, when I try to install it says 'The parameter > value is incorrect' > 2. xenvbd appears to install okay, but there are some odd messages in > the logs > 3. xenstub won't load, I get "xenstub.sys has been blocked from loading > due to incompatibility with this system." >=20 Disregard all of that. I was using the debugger and the debugger was offering the 32 bit drivers. All working now. James