Re: [Patch 08/10] input: Touchscreen driver for the PCAP

[Eric Miao <eric.y.miao@gmail.com>]

Stefan Schmidt wrote:
> Hello.
> 
> On Mon, 2008-07-07 at 16:13, Dmitry Torokhov wrote:
>> On Mon, Jul 07, 2008 at 08:40:08PM +0200, stefan@datenfreihafen.org wrote:
>>> +
>>> +	input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
>>> +	input_dev->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
>>> +	input_set_abs_params(input_dev, ABS_X, X_AXIS_MIN, X_AXIS_MAX, 0, 0);
>>> +	input_set_abs_params(input_dev, ABS_Y, Y_AXIS_MIN, Y_AXIS_MAX, 0, 0);
>>> +	input_set_abs_params(input_dev, ABS_PRESSURE, PRESSURE_MIN,
>>> +			     PRESSURE_MAX, 0, 0);
>>> +
>>> +	input_register_device(pcap_ts->input);
>> Please add error handling here, otherwise looks good.
> 
> Ok.New patch somes tomorrow. Need sleep now.
> 

Well, one small nit: I'm not a language lawyer, but I don't think usage of
u_int32_t/u_int16_t/u_int8_t is encourage nowadays, use uin32_t/uint16_t/uint8_t
or u32/u16/u8.

Note: I'm not going to start an argument on which is the correct one to
use, so it's totally up to you.