From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from netops-testserver-3-out.sgi.com ([192.48.171.28] helo=relay.sgi.com) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1KGHy4-0004s2-Ph for kexec@lists.infradead.org; Tue, 08 Jul 2008 18:31:13 +0000 Message-ID: <4873B242.1010002@sgi.com> Date: Tue, 08 Jul 2008 11:30:26 -0700 From: Jay Lan MIME-Version: 1.0 Subject: Re: [PATCH] Use progress bar also for bitmap creation References: <20080626143721.GA12486@suse.de> <4864B595.8040205@mxs.nes.nec.co.jp> <48718477.3020406@mxs.nes.nec.co.jp> <20080708174354.641d5a1a@halley.suse.de> In-Reply-To: <20080708174354.641d5a1a@halley.suse.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Bernhard Walle Cc: Ken'ichi Ohmichi , kexec@lists.infradead.org Bernhard Walle wrote: > * Ken'ichi Ohmichi [2008-07-07 11:50]: >> Ken'ichi Ohmichi wrote: >>> Hi Bernhard, >>> >>> Thank you for your patch. >>> I like this idea :-) >>> >>> I am busy now, and I will consider the patch well the next week. >> Thank you for the patch, and sorry for my late response. >> >> I added the progress bar for excluding free pages to your patch. >> Could you please check the attached patch ? >> If there is no problem in the attached patch, I will release the >> next release with this patch. > > I also tested on a larger SGI machine. Here the exclusion of the memory > holes takes a considerable amount of time. Therefore, I would suggest > to also use the patch below: By "memory holes", did you mean zero value memory or memory gap as you can see from /proc/iomem? For example, 26003000000-26033dfffff : System RAM 26033e00000-260f7ffffff : System RAM <-- big gap b/t this and next 26800000000-268f7ffffff : System RAM If latter, the gap represents address gap between nodes and are non-existent memory. We do not need to spend time on non-existent memory. Regards, - jay > > > Signed-off-by: Bernhard Walle > > Index: makedumpfile.c > =================================================================== > RCS file: /cvsroot/makedumpfile/makedumpfile/makedumpfile.c,v > retrieving revision 1.7.2.36 > diff -u -r1.7.2.36 makedumpfile.c > --- makedumpfile.c 8 Jul 2008 01:31:44 -0000 1.7.2.36 > +++ makedumpfile.c 8 Jul 2008 15:41:18 -0000 > @@ -40,6 +40,7 @@ > * Message texts > */ > #define PROGRESS_COPY "Copying data" > +#define PROGRESS_HOLES "Checking for memory holes" > #define PROGRESS_UNN_PAGES "Excluding unnecessary pages" > #define PROGRESS_FREE_PAGES "Excluding free pages" > #define PROGRESS_ZERO_PAGES "Excluding zero pages" > @@ -4068,11 +4069,20 @@ > */ > for (pfn = 0, paddr = 0; pfn < info->max_mapnr; > pfn++, paddr += info->page_size) { > + > + print_progress(PROGRESS_HOLES, pfn, info->max_mapnr); > + > if (is_in_segs(paddr)) > set_bit_on_1st_bitmap(pfn); > else > pfn_memhole++; > } > + > + /* > + * print 100 % > + */ > + print_progress(PROGRESS_HOLES, info->max_mapnr, info->max_mapnr); > + > if (!sync_1st_bitmap()) > goto out; > > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec