All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 0/2] Coldfire Ethernet initialization changes
Date: Tue, 08 Jul 2008 11:42:47 -0700	[thread overview]
Message-ID: <4873B527.3080707@gmail.com> (raw)
In-Reply-To: <4791E710007FEB4BBF83775D787F462F074599B8@az33exm22.fsl.freescale.net>

Liew Tsi Chung wrote:
> Ben,
>
>   
>> I'm pushing these patches to a 'testing' branch on the net repo.
>>     
> Please clone it as follows:
>   
>> $ git clone git://git.denx.de/u-boot-net.git $ cd u-boot-net $ git
>>     
> checkout testing
> There is no testing branch in u-boot-net, so I applied the two patches
> you sent on top of current u-boot-net tree (commit
> 63676841ca2d603b13765f3f7b72ff1a61c23f90 - Jun 18. Remove duplicate code
> in cpu/arm926ejs/davinci/lxt972.c).
>
>   
There is a testing branch in the repo:
http://git.denx.de/?p=u-boot/u-boot-net.git;a=shortlog;h=refs/heads/testing

I just don't know how to use git properly...
> Only one conflict and error:
> The first patch - CONFIG_FSLDMAFEC for 547x_8x and is correct.
> Then, the second patch - CONFIG_MCFFEC, appended #if after ||, either
> remove CONFIG_MCFFEC for 547x_8x or remove "#if ".
>
>   
Oh yeah, duh!  I need to free up some space on my hard drive so I can 
have more tools...
> -#if defined(CONFIG_FSLDMAFEC)
> +#if defined(CONFIG_FSLDMAFEC) || #if defined(CONFIG_MCFFEC)
> +/* Default initializations for MCFFEC controllers.  To override,
> + * create a board-specific function called:
> + * 	int board_eth_init(bd_t *bis)
> + */
> +
>  extern int mcdmafec_initialize(bd_t *bis);
> +extern int mcffec_initialize(bd_t*);
>   
Does it work after you fix this up?

thanks a lot!
Ben

  reply	other threads:[~2008-07-08 18:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-03  7:07 [U-Boot-Users] [PATCH 0/2] Coldfire Ethernet initialization changes Ben Warren
2008-07-03  7:07 ` [U-Boot-Users] [PATCH 1/2] Moved initialization of FSL_MCDMAFEC Ethernet driver to CPU directory Ben Warren
2008-07-03  7:07   ` [U-Boot-Users] [PATCH 2/2] Moved initialization of MCFFEC " Ben Warren
2008-07-03 17:39 ` [U-Boot-Users] [PATCH 0/2] Coldfire Ethernet initialization changes Liew Tsi Chung
2008-07-03 17:43   ` Ben Warren
2008-07-08 18:33 ` Liew Tsi Chung
2008-07-08 18:42   ` Ben Warren [this message]
2008-07-08 20:43     ` Liew Tsi Chung
2008-07-08 21:00       ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4873B527.3080707@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.