From: Patrick McHardy <kaber@trash.net>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: Nicolas Pitre <nico@cam.org>,
Dale Farnsworth <dale@farnsworth.org>,
Ashish Karkare <akarkare@marvell.com>,
Jesper Dangaard Brouer <jdb@comx.dk>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/2][RFC] vlan: use pskb_copy() when inserting a vlan tag by hand
Date: Tue, 08 Jul 2008 22:15:55 +0200 [thread overview]
Message-ID: <4873CAFB.8040606@trash.net> (raw)
In-Reply-To: <20080708193351.GE14330@xi.wantstofly.org>
Lennert Buytenhek wrote:
> On Tue, Jul 08, 2008 at 08:50:09PM +0200, Patrick McHardy wrote:
>
>> commit 9381fc4a49cb8b75d5ff38e4f5d14d7e135adc4c
>> Author: Patrick McHardy <kaber@trash.net>
>> Date: Tue Jul 8 19:56:17 2008 +0200
>>
>> vlan: avoid header copying and linearisation where possible
>
> That gives me:
>
> - 2.6.26-rc9 + [1] + [2] + this patch: ~75 sec, 13.6 MiB/s
>
> So it's almost back to the non-VLAN case.
Great, thanks. The patch applies cleanly with or without the VLAN
packet socket patches I sent today, so Dave can either just apply
it together with your mv643xx_eth patch or I'll include it when
sending the next VLAN update.
next prev parent reply other threads:[~2008-07-08 20:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 20:56 [PATCH 1/2][RFC] vlan: use pskb_copy() when inserting a vlan tag by hand Lennert Buytenhek
2008-07-07 21:01 ` Patrick McHardy
2008-07-07 21:07 ` Lennert Buytenhek
2008-07-07 21:15 ` Patrick McHardy
2008-07-08 16:24 ` Patrick McHardy
2008-07-08 17:41 ` Patrick McHardy
2008-07-08 18:52 ` Lennert Buytenhek
2008-07-08 18:50 ` Patrick McHardy
2008-07-08 19:33 ` Lennert Buytenhek
2008-07-08 20:15 ` Patrick McHardy [this message]
2008-07-08 22:02 ` David Miller
2008-07-08 22:18 ` Patrick McHardy
2008-07-08 22:37 ` David Miller
2008-07-08 22:10 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4873CAFB.8040606@trash.net \
--to=kaber@trash.net \
--cc=akarkare@marvell.com \
--cc=buytenh@wantstofly.org \
--cc=dale@farnsworth.org \
--cc=davem@davemloft.net \
--cc=jdb@comx.dk \
--cc=netdev@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.