From: Mark Levedahl <mlevedahl@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-submodule - register module url if adding in place
Date: Tue, 08 Jul 2008 19:59:42 -0400 [thread overview]
Message-ID: <4873FF6E.2020602@gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0807081332580.4319@eeepc-johanness>
Johannes Schindelin wrote:
> I agree with Sylvain here, namely that this is too dangerous. Imagine
> this very valid scenario:
>
> $ git clone <somewhere> abc
> $ git submodule add abc
>
> Bummer.
>
> Yes, happened to me.
>
> So I'd like this to be an error, not something that tries to be helpful,
> when it clearly cannot be.
>
> Ciao,
> Dscho
>
>
I think the real issue here is that submodule-add is too flexible and
poorly documented, see my response to Junio in the other thread.
Mark
next prev parent reply other threads:[~2008-07-09 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 2:37 [PATCH] git-submodule - register module url if adding in place Mark Levedahl
2008-07-08 11:34 ` Johannes Schindelin
2008-07-08 23:59 ` Mark Levedahl [this message]
2008-07-09 0:11 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4873FF6E.2020602@gmail.com \
--to=mlevedahl@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.