Re: [ath5k-devel] [PATCH] ath5k: convert LED code to use mac80211 triggers

[Helge Deller <deller@gmx.de>]

Bob Copeland wrote:
> On Tue, Jul 8, 2008 at 7:08 PM, Helge Deller <deller@gmx.de> wrote:
>> I tested it against Linus' head version (it applied with minor
>> modifications) on my HP NC6000 laptop with this built-in Atheros card:
> [...]
>> Basically it works, but I think the sc->led_on in:
>>> +     sc->led_on = 0;  /* active low */
>> needs to be:
>>> +     sc->led_on = 1;  /* active high */
>> for the AR5212 in the HP laptop.
> 
> Thanks for the test!
> 
>> See also the changes to if_ath_pci.c in:
>>  http://madwifi.org/attachment/ticket/1018/led.patch
>> and
>>  http://madwifi.org/ticket/1018
>> for an old discussion about madwifi for LEDs in the HP box.
> 
> So current madwifi doesn't have this change unless I missed something?

Yes, the patch has not been applied yet.

>  It appears to use active-low leds in the current version regardless
> of the vendor.

Yes.

Helge