From: Ronny.Hegewald@online.de
To: konrad.wilk@oracle.com
Cc: xen-devel@lists.xensource.com
Subject: Re: pvops dom0: no sound after boot; possibly causedbyswiotlb
Date: Fri, 05 Feb 2010 21:09:03 +0100 [thread overview]
Message-ID: <4874651.4118551265400543057.JavaMail.servlet@kundenserver> (raw)
>> No, your first statement was correct. It would always return the same mask
>for 32-bit and 64-bit, because of the 32-bitness of the return-variable
>'dma_mask'.
>>
>> So the following patch maybe would be more appropriate?
>
>I think it isn't neccessary. The 'dmal_alloc_coherent_mask' returns an
>unsigned long. On 32-bit 'unsigned long' is a 4-byte value, and
>on 64-bit that is 8-byte value.
Oh yes, right, didnt thought about that ....
So I think your previous patch:
>http://lists.xensource.com/archives/html/xen-devel/2010-02/msg00038.html
>is correct as when it is compiled under 64-bit it would return a 64-bit
>value and when compiled under 32-bit, it would return a 32-bit value.
As it seems that the patch wasn't noticed i will resend it. Can i add a Reviewed-by (or Acked-by) from you to the patch, so it gets more attention?
next reply other threads:[~2010-02-05 20:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 20:09 Ronny.Hegewald [this message]
2010-02-05 21:38 ` pvops dom0: no sound after boot; possibly causedbyswiotlb Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4874651.4118551265400543057.JavaMail.servlet@kundenserver \
--to=ronny.hegewald@online.de \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.