All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	hemao77@gmail.com, bugme-daemon@bugzilla.kernel.org,
	netdev@vger.kernel.org,
	Netfilter Development Mailinglist
	<netfilter-devel@vger.kernel.org>
Subject: Re: [Bugme-new] [Bug 11058] New: DEADLOOP in kernel network module
Date: Wed, 09 Jul 2008 17:00:33 +0200	[thread overview]
Message-ID: <4874D291.1010707@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0807091519380.11391@blackhole.kfki.hu>

Jozsef Kadlecsik wrote:
> On Wed, 9 Jul 2008, Patrick McHardy wrote:
> 
>> Good catch, thanks. Basically all del_timer()/timeout.function calls
>> in conntrack can happen in process context, so we'd have to disable
>> BHs every time we do this. I think this fix should also work. The
>> only spot where we return NF_REPEAT is in TCP conntrack, so we can
>> simply make sure we only do this if we actually managed to kill the
>> connection.
>>
>> Jozsef, what do you think?
> 
> I agree with you completely - and nice catch, indeed! Your proposed patch 
> looks just fine.

Thanks, I'll send a backport for 2.6.26 to Dave tonight.

  reply	other threads:[~2008-07-09 15:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-11058-10286@http.bugzilla.kernel.org/>
2008-07-09  4:00 ` [Bugme-new] [Bug 11058] New: DEADLOOP in kernel network module Andrew Morton
2008-07-09 12:45   ` Patrick McHardy
2008-07-09 13:27     ` Jozsef Kadlecsik
2008-07-09 15:00       ` Patrick McHardy [this message]
2008-07-09 16:32         ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4874D291.1010707@trash.net \
    --to=kaber@trash.net \
    --cc=akpm@linux-foundation.org \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=hemao77@gmail.com \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.