From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Marek Vasut <marek.vasut@mailbox.org>, <u-boot@lists.denx.de>
Cc: Gabriel Fernandez <gabriel.fernandez@foss.st.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Sean Anderson <seanga2@gmail.com>, Tom Rini <trini@konsulko.com>,
<uboot-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH] clk: stm32: Pass udevice pointer to clk_register_composite()
Date: Wed, 17 Sep 2025 09:26:57 +0200 [thread overview]
Message-ID: <4875df2a-fcd4-4576-8564-37bb3dad4eae@foss.st.com> (raw)
In-Reply-To: <fc2696fa-04bb-494c-8c48-7cf7eb09d70c@foss.st.com>
On 9/8/25 09:02, Patrice CHOTARD wrote:
>
>
> On 9/7/25 01:00, Marek Vasut wrote:
>> The clk_register_composite() does clk_resolve_parent_clk() look up,
>> which requires valid udevice pointer. Do not pass NULL, pass a valid
>> device pointer to prevent hang on registering ck_usbo_48m clock on
>> STM32MP13xx.
>>
>> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
>> ---
>> Cc: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
>> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
>> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> Cc: Sean Anderson <seanga2@gmail.com>
>> Cc: Tom Rini <trini@konsulko.com>
>> Cc: u-boot@lists.denx.de
>> Cc: uboot-stm32@st-md-mailman.stormreply.com
>> ---
>> drivers/clk/stm32/clk-stm32-core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/stm32/clk-stm32-core.c b/drivers/clk/stm32/clk-stm32-core.c
>> index a0ae89d0912..858f122db1a 100644
>> --- a/drivers/clk/stm32/clk-stm32-core.c
>> +++ b/drivers/clk/stm32/clk-stm32-core.c
>> @@ -309,7 +309,7 @@ clk_stm32_register_composite(struct udevice *dev,
>> gate_ops = &clk_stm32_gate_ops;
>> }
>>
>> - clk = clk_register_composite(NULL, cfg->name,
>> + clk = clk_register_composite(dev, cfg->name,
>> parent_names, num_parents,
>> mux_clk, mux_ops,
>> div_clk, div_ops,
>
> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
>
> Thanks
> Patrice
Applied to u-boot-stm32/master
Thanks
Patrice
prev parent reply other threads:[~2025-09-17 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-06 23:00 [PATCH] clk: stm32: Pass udevice pointer to clk_register_composite() Marek Vasut
2025-09-08 7:02 ` Patrice CHOTARD
2025-09-17 7:26 ` Patrice CHOTARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4875df2a-fcd4-4576-8564-37bb3dad4eae@foss.st.com \
--to=patrice.chotard@foss.st.com \
--cc=gabriel.fernandez@foss.st.com \
--cc=marek.vasut@mailbox.org \
--cc=patrick.delaunay@foss.st.com \
--cc=seanga2@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.