All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: "Yang, Sheng" <sheng.yang@intel.com>
Cc: kvm@vger.kernel.org, Glauber Costa <gcosta@redhat.com>,
	glommer@gmail.com, avi@qumranet.com
Subject: Re: [PATCH] mask out clflush
Date: Thu, 10 Jul 2008 08:30:14 -0500	[thread overview]
Message-ID: <48760EE6.1070303@codemonkey.ws> (raw)
In-Reply-To: <200807101843.57902.sheng.yang@intel.com>

Yang, Sheng wrote:
> On Wednesday 09 July 2008 02:29:44 Glauber Costa wrote:
>   
>> clflush is a non-privileged instruction that flushes the cacheline
>> given by its parameter, in terms of linear address. As it is
>> non-privileged, it is quite tricky, because a guest doing clflush
>> will actually be trying to flush a host kernel address.
>>     
>
> The linear address was convert to host physical address, then cache 
> line was flushed. Of course the host physical address was used by 
> guest at the time. I don't understand why we need to prevent guest 
> from flushing cache line related to itself...
>   

The problem turned out to be that we aren't emulating clflush in 
x86_emulate.

Regards,

Anthony Liguori

> --
> Thanks
> Yang, Sheng
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>   


  reply	other threads:[~2008-07-10 13:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-08 18:29 [PATCH] mask out clflush Glauber Costa
2008-07-08 19:34 ` Anthony Liguori
2008-07-08 20:01   ` Glauber Costa
2008-07-10 10:43 ` Yang, Sheng
2008-07-10 13:30   ` Anthony Liguori [this message]
2008-07-10 13:34     ` Avi Kivity
2008-07-10 13:37       ` Anthony Liguori
2008-07-10 14:10         ` Avi Kivity
2008-07-10 14:20           ` Anthony Liguori
2008-07-10 14:45             ` Glauber Costa
2008-07-10 14:47               ` Avi Kivity
2008-07-10 15:37                 ` Anthony Liguori
2008-07-10 15:39                   ` Avi Kivity
2008-07-10 20:18                     ` Glauber Costa
2008-07-13  7:58                       ` Avi Kivity
2008-07-10 14:16 ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48760EE6.1070303@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=avi@qumranet.com \
    --cc=gcosta@redhat.com \
    --cc=glommer@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=sheng.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.