From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Przywara Subject: [qemu-xen]: Fix warnings Date: Thu, 10 Jul 2008 17:15:21 +0200 Message-ID: <48762789.4010202@amd.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000103070604000007020301" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --------------000103070604000007020301 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Ian, first thanks for updating qemu/ioemu to a more recent version, that gives a lot of nice features. Below patch fixes two warnings when compiling. If slirp is out of the way, we have only one warning left (monitor.c:69) that prevents us from setting --enable-werror (at least on my setup ;-) This fix is not trivial: - Either refactor the whole monitor code to use other ways of calling the handler functions or - use casts at every call Does anyone know of a method preventing gcc to give this particular warning at this particular code line (some kind of pragma?) This would be a much easier solution than the above ones. Signed-off-by: Andre Przywara Regards, Andre. -- Andre Przywara AMD-Operating System Research Center (OSRC), Dresden, Germany Tel: +49 351 277-84917 ----to satisfy European Law for business letters: AMD Saxony Limited Liability Company & Co. KG, Wilschdorfer Landstr. 101, 01109 Dresden, Germany Register Court Dresden: HRA 4896, General Partner authorized to represent: AMD Saxony LLC (Wilmington, Delaware, US) General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy --------------000103070604000007020301 Content-Type: text/plain; name="ioemu-remote.warnings.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ioemu-remote.warnings.patch" diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c index 60084cf..3973c25 100644 --- a/hw/scsi-generic.c +++ b/hw/scsi-generic.c @@ -478,8 +478,8 @@ static int32_t scsi_send_command(SCSIDevice *d, uint32_t tag, uint8_t *cmd, int lun) { SCSIDeviceState *s = d->state; - uint32_t len; - int cmdlen; + uint32_t len=0; + int cmdlen=0; SCSIRequest *r; int ret; diff --git a/i386-dm/helper2.c b/i386-dm/helper2.c index 6437c37..d630cb0 100644 --- a/i386-dm/helper2.c +++ b/i386-dm/helper2.c @@ -418,7 +418,8 @@ void cpu_ioreq_timeoffset(CPUState *env, ioreq_t *req) time_offset += (unsigned long)req->data; - fprintf(logfile, "Time offset set %ld, added offset %lld\n", time_offset, req->data); + fprintf(logfile, "Time offset set %ld, added offset %"PRId64"\n", + time_offset, req->data); sprintf(b, "%ld", time_offset); xenstore_vm_write(domid, "rtc/timeoffset", b); } --------------000103070604000007020301 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------000103070604000007020301--