From: Wang Jian <lark@linux.net.cn>
To: netdev@vger.kernel.org
Cc: Alexandr Smirnov <asmirnov@ru.mvista.com>,
Andy Fleming <afleming@freescale.com>
Subject: [PATCH 1/2] Fix copper/fiber auto-selection for 88e1111
Date: Fri, 11 Jul 2008 08:55:25 +0800 [thread overview]
Message-ID: <4876AF7D.2090402@linux.net.cn> (raw)
The 27.15 bit (MII_M1111_HWCFG_FIBER_COPPER_AUTO) is disable bit. When
set to 1, copper/fiber auto selection is disabled. The current code
to enable but actually disable auto selection.
Signed-off-by: Wang Jian <lark@linux.net.cn>
---
drivers/net/phy/marvell.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index 32a8503..737512c 100644
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -162,7 +162,7 @@ static int m88e1111_config_init(struct phy_device
*phydev)
/* Enable Fiber/Copper auto selection */
temp = phy_read(phydev, MII_M1111_PHY_EXT_SR);
- temp |= MII_M1111_HWCFG_FIBER_COPPER_AUTO;
+ temp &= ~MII_M1111_HWCFG_FIBER_COPPER_AUTO;
phy_write(phydev, MII_M1111_PHY_EXT_SR, temp);
temp = phy_read(phydev, MII_BMCR);
--
1.5.5.4
next reply other threads:[~2008-07-11 1:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 0:55 Wang Jian [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-07-16 13:46 [PATCH 1/2] Fix copper/fiber auto-selection for 88e1111 Wang Jian
2008-07-22 22:02 ` Jeff Garzik
2008-07-10 2:14 Wang Jian
2008-07-14 13:21 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4876AF7D.2090402@linux.net.cn \
--to=lark@linux.net.cn \
--cc=afleming@freescale.com \
--cc=asmirnov@ru.mvista.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.