All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: Andrew Vasquez <andrew.vasquez@qlogic.com>
Cc: Linux SCSI Mailing List <linux-scsi@vger.kernel.org>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Seokmann Ju <seokmann.ju@qlogic.com>
Subject: Re: [PATCH 02/18] qla2xxx: Add dev_loss_tmo_callbk/terminate_rport_io callback support.
Date: Fri, 11 Jul 2008 12:37:21 -0500	[thread overview]
Message-ID: <48779A51.5070403@cs.wisc.edu> (raw)
In-Reply-To: <1215734163-40825-2-git-send-email-andrew.vasquez@qlogic.com>

Andrew Vasquez wrote:
> +static void
> +qla2x00_terminate_rport_io(struct fc_rport *rport)
> +{
> +	fc_port_t *fcport = *(fc_port_t **)rport->dd_data;
> +
> +	qla2x00_abort_fcport_cmds(fcport);


Hey, I was also wondering how we get commands still in the driver at 
this point? I was doing some testing on my patches and could not hit it. 
Does it only occur with things like tape commands or what type of errors 
would block/remove the rport but not end up failing the commands at the 
time the error is detected? Like with the CS_TIMEOUT case I hit here
http://marc.info/?l=linux-scsi&m=121263015108620&w=2
the IO is failed right away, so when I got to where the terminate 
callback is called there was no IO in the driver.

Thanks.

  parent reply	other threads:[~2008-07-11 17:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-10 23:54 [PATCH 0/18] qla2xxx: updates for 2.6.27 [8.02.01-k5] Andrew Vasquez
2008-07-10 23:55 ` [PATCH 01/18] qla2xxx: Correct locking during NVRAM manipulation Andrew Vasquez
2008-07-10 23:55 ` [PATCH 02/18] qla2xxx: Add dev_loss_tmo_callbk/terminate_rport_io callback support Andrew Vasquez
2008-07-11 17:32   ` Mike Christie
2008-07-11 18:04     ` [RESEND PATCH " Andrew Vasquez
2008-07-11 18:21       ` Mike Christie
2008-07-11 19:16         ` Andrew Vasquez
2008-07-11 18:17     ` [PATCH] fc_transport: remove explicit calls to scsi_target_unblock() from terminate_rport_io() callbacks Andrew Vasquez
2008-07-11 17:37   ` Mike Christie [this message]
2008-07-11 17:49     ` [PATCH 02/18] qla2xxx: Add dev_loss_tmo_callbk/terminate_rport_io callback support Andrew Vasquez
2008-07-10 23:55 ` [PATCH 03/18] qla2xxx: Set an rport's dev_loss_tmo value in a consistent manner Andrew Vasquez
2008-07-10 23:55 ` [PATCH 04/18] qla2xxx: Track total number of ISP aborts Andrew Vasquez
2008-07-10 23:55 ` [PATCH 05/18] qla2xxx: Add LIP count to FC-transport statistics Andrew Vasquez
2008-07-10 23:55 ` [PATCH 06/18] qla2xxx: Cleanup NPIV related functions Andrew Vasquez
2008-07-10 23:55 ` [PATCH 07/18] qla2xxx: Allow the user the option of disabling iIDMA Andrew Vasquez
2008-07-10 23:55 ` [PATCH 08/18] qla2xxx: Retrieve board serial-number and description from VPD Andrew Vasquez
2008-07-10 23:55 ` [PATCH 09/18] qla2xxx: Swap enablement order of EFT and FCE Andrew Vasquez
2008-07-10 23:55 ` [PATCH 10/18] qla2xxx: Always aquire the parent's hardware_lock Andrew Vasquez
2008-07-10 23:55 ` [PATCH 11/18] qla2xxx: Correct fcport state-management during loss Andrew Vasquez
2008-07-10 23:55 ` [PATCH 12/18] qla2xxx: Correct vport management of MBA_PORT_UPDATE Andrew Vasquez
2008-07-10 23:55 ` [PATCH 13/18] qla2xxx: Correct rport/fcport visibility-state handling during loop-resync Andrew Vasquez
2008-07-10 23:55 ` [PATCH 14/18] qla2xxx: Skip FDMI registration on ISP21xx/22xx parts Andrew Vasquez
2008-07-10 23:56 ` [PATCH 15/18] qla2xxx: Correct overflow during dump-processing on large-memory ISP23xx parts Andrew Vasquez
2008-07-10 23:56 ` [PATCH 16/18] qla2xxx: Verify the RISC is not in ROM code if firmware-load is disabled Andrew Vasquez
2008-07-10 23:56 ` [PATCH 17/18] qla2xxx: Don't hardcode fw_transfer_size for ISP2[45]xx parts Andrew Vasquez
2008-07-10 23:56 ` [PATCH 18/18] qla2xxx: Update version number to 8.02.01-k5 Andrew Vasquez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48779A51.5070403@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=andrew.vasquez@qlogic.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=seokmann.ju@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.