Re: Mac OS X support patch

["H. Peter Anvin" <hpa@zytor.com>]

Herbert Xu wrote:
> H. Peter Anvin <hpa@zytor.com> wrote:
>> Mark Mentovai wrote:
>>> - open64 is not present although the stat64 family is, separate the
>>>   autoconf checks
>> This seems like the Wrong Thing anyway; the right thing should be to add 
>> whatever option (like -D_FILE_OFFSET_BITS=64 on Linux) to do 
>> *everything* using the full-sized offsets.
> 
> Actually there is a reason for this.  Not all open(2) calls in
> dash need large file support.  For example, doing it on a shell
> script or /dev/null makes no sense.  Only those dealing with user
> files (redirections) need large file support.
> 
> So that's we need to differentiate between open(2) calls on user
> files as opposed to those for dash itself.
> 

I'm not sure that that makes sense, however.  Unless you're hauling a 
*lot* of off_t's around the code, the incremental complexity is hardly 
worth it.

The *only* reason for the legacy 32-bit off_t mode is because it is an 
ABI change, it is necessary to prevent application/library interface 
breakage.

FWIW, klibc doesn't even implement the LFS64 APIs, nor does it implement 
the legacy 32-bit off_t mode in any way.

	-hpa