From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: qemu-dm without slirp
Date: Mon, 14 Jul 2008 14:40:48 -0700
Message-ID: <487BC7E0.9040106@goop.org>
References: <C4A0BAEA.1AF3A%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C4A0BAEA.1AF3A%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Keir Fraser <keir.fraser@eu.citrix.com>, Jean Guyader <jean.guyader@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

Keir Fraser wrote:
> On 13/7/08 07:27, "Jeremy Fitzhardinge" <jeremy@goop.org> wrote:
>
>   
>> Jeremy Fitzhardinge wrote:
>>     
>>> but other stuff is failing... tapdisk?
>>>       
>> No, pvfb.  Hm.
>>     
>
> pvfb is built into qemu now?
>   

Ah.  I compiled qemu with --disable-gcc-check --disable-slirp as had 
been discussed on the list.  But that causes qemu-dm to fail with 
"Unknown network device: user", because it always  uses "user" (slirp) 
if you don't define any other net conifg.

I did this:

--- a/vl.c
+++ b/vl.c
@@ -8598,9 +8598,10 @@ int main(int argc, char **argv)
     /* init network clients */
     if (nb_net_clients == 0) {
         /* if no clients, we use a default config */
-        net_clients[0] = "nic";
-        net_clients[1] = "user";
-        nb_net_clients = 2;
+        net_clients[nb_net_clients++] = "nic";
+#ifdef CONFIG_SLIRP
+        net_clients[nb_net_clients++] = "user";
+#endif
     }
 
     for(i = 0;i < nb_net_clients; i++) {

to fix it.  The old qemu code put that whole default net configuration 
in #ifndef CONFIG_DM.  Ian, did you deliberately not do that in the new 
code, or is it an oversight?

    J