From: Wang Chen <wangchen@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH] af_packet: po->mclist needs locker in reader side
Date: Tue, 15 Jul 2008 18:32:45 +0800 [thread overview]
Message-ID: <487C7CCD.8060708@cn.fujitsu.com> (raw)
In-Reply-To: <20080715.021144.85711463.davem@davemloft.net>
David Miller said the following on 2008-7-15 17:11:
> From: Wang Chen <wangchen@cn.fujitsu.com>
> Date: Tue, 15 Jul 2008 15:52:31 +0800
>
>> As my understanding, packet_dev_mclist() is the only reader who doesn't
>> use same lock as writers(actually it doesn't use any lock).
>> My proposal is that use RTNL to prevent synchronous access to po->mclist.
>> Because packet_dev_mclist() is only called when device be unregistered,
>> the lock will not affect speed too much.
>>
>> Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
>
> I took a look and it turns out that the RTNL lock is already held when
> that notifier runs, so it seems everything is fine here already.
>
> So I'll ignore this patch :)
Yes. register_netdevice() holds the lock ;)
next prev parent reply other threads:[~2008-07-15 10:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <487C0ABA.1070506@cn.fujitsu.com>
2008-07-15 2:59 ` v4 [PATCH 1/9] af_packet: Check return of dev_set_promiscuity/allmulti Wang Chen
2008-07-15 3:51 ` David Miller
2008-07-15 7:52 ` [PATCH] af_packet: po->mclist needs locker in reader side(WAS: [PATCH 1/9] af_packet: Check return of dev_set_promiscuity/allmulti) Wang Chen
2008-07-15 9:11 ` [PATCH] af_packet: po->mclist needs locker in reader side David Miller
2008-07-15 10:32 ` Wang Chen [this message]
2008-07-15 2:59 ` v4 [PATCH 2/9] bonding: Check return of dev_set_promiscuity/allmulti Wang Chen
2008-07-15 3:51 ` David Miller
2008-07-15 2:59 ` v4 [PATCH 3/9] bridge: Check return of dev_set_promiscuity Wang Chen
2008-07-15 3:54 ` David Miller
2008-07-15 2:59 ` v4 [PATCH 4/9] ipv6: Check return of dev_set_allmulti Wang Chen
2008-07-15 3:54 ` David Miller
2008-07-15 2:59 ` v4 [PATCH 5/9] ipv6: Fix using after dev_put() Wang Chen
2008-07-15 3:55 ` David Miller
2008-07-15 2:59 ` v4 [PATCH 6/9] ipv4: Check return of dev_set_allmulti Wang Chen
2008-07-15 3:55 ` David Miller
2008-07-15 2:59 ` v4 [PATCH 7/9] ipv4: Fix ipmr unregister device oops Wang Chen
2008-07-15 3:56 ` David Miller
2008-07-15 2:59 ` v4 [PATCH 8/9] macvlan: Check return of dev_set_allmulti Wang Chen
2008-07-15 3:57 ` David Miller
2008-07-15 2:59 ` v4 [PATCH 9/9] 8021q: Check return of dev_set_promiscuity/allmulti Wang Chen
2008-07-15 4:00 ` David Miller
2008-07-15 6:04 ` Wang Chen
2008-07-17 5:41 ` git clone net-next-2.6 Wang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487C7CCD.8060708@cn.fujitsu.com \
--to=wangchen@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.