From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Wolf <kwolf@suse.de>
Subject: Re: [PATCH] xend: PV machines have no ioemu network
Date: Tue, 15 Jul 2008 18:44:46 +0200
Message-ID: <487CD3FE.50800@suse.de>
References: <C4A0BAEA.1AF3A%keir.fraser@eu.citrix.com>
	<487BC7E0.9040106@goop.org> <487C66CF.1030104@suse.de>
	<487CBBBE.4050405@goop.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <487CBBBE.4050405@goop.org>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: xen-devel@lists.xensource.com, Ian Jackson <Ian.Jackson@eu.citrix.com>, Keir Fraser <keir.fraser@eu.citrix.com>, Jean Guyader <jean.guyader@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

Jeremy Fitzhardinge schrieb:
> Kevin Wolf wrote:
>> Ians wants to keep changes from upstream qemu as small as possible in
>> those files shared with qemu. I think this is the main reason why he
>> didn't do it, and as long as slirp was compiled it just worked.
>>
>> Additionally, specifying no -net parameter always meant -net nic -net
>> user for qemu, so we would not only change common code, but also the
>> semantics of the command line parameters. I think this is even worse.
>>   
> 
> If you've disabled slirp then "-net user" doesn't work; it would be
> pretty silly for qemu to default to using "-net user" if it can't
> possibly work.  I think my patch is a bugfix for base qemu.

Agreed. If you submit it to upstream qemu, it's a proper fix.

Kevin