From: Brian King <brking@linux.vnet.ibm.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Daniel Debonzi <debonzi@linux.vnet.ibm.com>, linux-scsi@vger.kernel.org
Subject: Re: scsi_host_alloc does not check for used shost->host_no
Date: Tue, 15 Jul 2008 15:31:47 -0500 [thread overview]
Message-ID: <487D0933.1010201@linux.vnet.ibm.com> (raw)
In-Reply-To: <20080715202507.GI14894@parisc-linux.org>
Matthew Wilcox wrote:
> Or we could make the host_no a u64 and avoid the problem ever happening
> in our lifetimes. I'm amazed that anyone's had the time to do 4 billion
> add/removes, to be honest. Assuming it takes 1 second per add/remove
> cycle, and there's not even time to scan a bus in that time, that's
> still 136 years.
That was my thought as well, until I checked struct scsi_host and saw
that hostno is actually defined as a short there, which makes the problem
slightly easier to hit. So, we could just increase both of them to u64's
and be done with it...
-Brian
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
next prev parent reply other threads:[~2008-07-15 20:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 13:19 scsi_host_alloc does not check for used shost->host_no Daniel Debonzi
2008-07-15 20:16 ` Brian King
2008-07-15 20:25 ` Matthew Wilcox
2008-07-15 20:31 ` Brian King [this message]
2008-07-15 20:54 ` [PATCH] Make host_no an unsigned int Matthew Wilcox
2008-07-15 20:34 ` scsi_host_alloc does not check for used shost->host_no James Bottomley
2008-07-15 21:39 ` Daniel Debonzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487D0933.1010201@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=debonzi@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.