All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <teheo@suse.de>
To: Neil Brown <neilb@suse.de>
Cc: Greg K-H <gregkh@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC] sysfs: Support sysfs_notify from atomic context with new sysfs_notify_dirent
Date: Wed, 16 Jul 2008 08:13:05 +0900	[thread overview]
Message-ID: <487D2F01.5000404@suse.de> (raw)
In-Reply-To: <18557.11132.728439.827572@notabene.brown>

Hello,

Neil Brown wrote:
> +#undef sysfs_get
> +struct sysfs_dirent *sysfs_get(struct sysfs_dirent *sd)
> +{
> +	return __sysfs_get(sd);
> +}
> +EXPORT_SYMBOL_GPL(sysfs_get);
> +
> +#undef sysfs_put
> +void sysfs_put(struct sysfs_dirent *sd)
> +{
> +	__sysfs_put(sd);
> +}
> +EXPORT_SYMBOL_GPL(sysfs_put);

I don't think this inline technique is really necessary.  Please just
drop the inline versions.  Other than that,

Acked-by: Tejun Heo <tj@kernel.org>

BTW, things like this strongly suggest that we really should switch to
sd-based interface instead of combination of kobj and optional name string.

Thanks.

-- 
tejun

  reply	other threads:[~2008-07-15 23:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-15 22:58 [PATCH/RFC] sysfs: Support sysfs_notify from atomic context with new sysfs_notify_dirent Neil Brown
2008-07-15 23:13 ` Tejun Heo [this message]
2008-07-20  6:31   ` Neil Brown
2008-07-23  6:09     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487D2F01.5000404@suse.de \
    --to=teheo@suse.de \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.