From: Patrick McHardy <kaber@trash.net>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Allan, Bruce W" <bruce.w.allan@intel.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
"Ronciak, John" <john.ronciak@intel.com>
Subject: [PATCH 0/2]: VLAN filtering fixes
Date: Wed, 16 Jul 2008 11:43:32 +0200 [thread overview]
Message-ID: <487DC2C4.9030006@trash.net> (raw)
These two patches contain the last bits of my VLAN + tcpdump fixes.
Currently some (all?) drivers have inconsistent behaviour wrt. VLAN
filtering and promiscous mode:
They start with disabled VLAN filtering, meaning all VLAN packets
are received on packet sockets. When adding the first VLAN, VLAN
filtering is enabled and only packets for locally configured VLANs
are received, even in promiscous mode. In most cases VLAN filtering
is disabled again when removing the last VLAN, igxbe keeps it enabled
permanently however.
These patches change the Intel drivers to always enable VLAN filtering
while not in promiscous mode since there is little point in receiving
VLAN packets while nothing is interested in them, but disable filtering
while in promiscous mode so all VLANs are visible to packet sockets.
There are four more drivers that support VLAN filtering that I didn't
adapt to this behaviour since I'm not sure about what exactly they
currently do. All four of tehuti, starfire, ehea and via-velocity
have a flag for the hardware to enable promiscous mode, its unknown
to me whether this also automatically disables VLAN filtering.
Any information on this someone might have is appreciated.
next reply other threads:[~2008-07-16 9:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 9:43 Patrick McHardy [this message]
2008-07-16 9:44 ` [PATCH 1/2]: netdrv intel: disable VLAN filtering in promiscous mode Patrick McHardy
2008-07-16 9:44 ` [PATCH 2/2]: netdrv intel: always enable VLAN filtering except " Patrick McHardy
2008-07-16 21:03 ` [PATCH 0/2]: VLAN filtering fixes Jeff Kirsher
2008-07-17 3:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487DC2C4.9030006@trash.net \
--to=kaber@trash.net \
--cc=bruce.w.allan@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jgarzik@pobox.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.