Re: [Xenomai-help] rt_task_bind() and timeout values

[Stefan Kisdaroczi <kisda@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 2495 bytes --]

Hi,

your patch didnt work. The bind_calls are now blocking infinite (at least much too long, still waiting...)
To compile i had to change following line in your patch:
-	if (timeout != TM_NONBLOCK && timeout != TM_INFINITE)
+	if (timeout != XN_NONBLOCK && timeout != XN_INFINITE)

I will use following patch for the moment, this works.

--- xenomai/nucleus/registry.c.old	2008-07-15 00:36:10.000000000 +0200
+++ xenomai/nucleus/registry.c	2008-07-15 15:28:23.000000000 +0200
@@ -733,8 +733,10 @@ int xnregistry_bind(const char *key, xnt
  		if (timeout != XN_INFINITE) {
  			xnticks_t now = xntbase_get_time(tbase);

-			if (stime + timeout >= now)
-				break;
+			if (stime + timeout <= now) {
+				err = -ETIMEDOUT;
+				goto unlock_and_exit;
+			}		

  			timeout -= (now - stime);
  			stime = now;


Philippe Gerum schrieb:
> Stefan Kisdaroczi wrote:
>> Hi Philippe,
>>
>> the attached patch fixed the problem for me.
> 
> Good spot. Now it's official, since four years that feature exists or so, nobody
> actually used registry timeouts... Oh, well...
> 
>> However, i think that in the "break case" still EACCES is returned.
>> Can the break be replaced with a "return ETIMEDOUT" ?
>>
> 
> Yes, normally we should do that along with your patch. Actually, the most
> appropriate fix would be to use an absolute timeout value internally, since the
> nucleus allows it.
> 
> --- ksrc/nucleus/registry.c	(revision 4044)
> +++ ksrc/nucleus/registry.c	(working copy)
> @@ -711,7 +711,6 @@
>  	xnobject_t *object;
>  	xnthread_t *thread;
>  	xntbase_t *tbase;
> -	xnticks_t stime;
>  	int err = 0;
>  	spl_t s;
> 
> @@ -723,7 +722,8 @@
> 
>  	xnlock_get_irqsave(&nklock, s);
> 
> -	stime = xntbase_get_time(tbase);
> +	if (timeout != TM_NONBLOCK && timeout != TM_INFINITE)
> +		timeout += xntbase_get_time(tbase);
> 
>  	for (;;) {
>  		object = registry_hash_find(key);
> @@ -738,18 +738,8 @@
>  			goto unlock_and_exit;
>  		}
> 
> -		if (timeout != XN_INFINITE) {
> -			xnticks_t now = xntbase_get_time(tbase);
> -
> -			if (stime + timeout >= now)
> -				break;
> -
> -			timeout -= (now - stime);
> -			stime = now;
> -		}
> -
>  		thread->registry.waitkey = key;
> -		xnsynch_sleep_on(&registry_hash_synch, timeout, XN_RELATIVE);
> +		xnsynch_sleep_on(&registry_hash_synch, timeout, XN_ABSOLUTE);
> 
>  		if (xnthread_test_info(thread, XNTIMEO)) {
>  			err = -ETIMEDOUT;
>  --
> Philippe.
> 
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]