All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [4875] Remove unintended dereference, kills a warning (Jan Kiszka).
Date: Wed, 16 Jul 2008 14:10:01 +0200	[thread overview]
Message-ID: <487DE519.3030202@web.de> (raw)
In-Reply-To: <761ea48b0807160436s6fd84eb4p6982eb4660c7df04@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

Laurent Desnogues wrote:
> On Wed, Jul 16, 2008 at 1:31 PM, Andrzej Zaborowski <balrogg@gmail.com> wrote:
>> Modified: trunk/target-sh4/op.c
>> ===================================================================
>> --- trunk/target-sh4/op.c       2008-07-16 04:45:12 UTC (rev 4874)
>> +++ trunk/target-sh4/op.c       2008-07-16 11:31:11 UTC (rev 4875)
>> @@ -594,8 +594,8 @@
>>
>>  void OPPROTO op_tasb_rN(void)
>>  {
>> -    cond_t(*(int8_t *) env->gregs[PARAM1] == 0);
>> -    *(int8_t *) env->gregs[PARAM1] |= 0x80;
>> +    cond_t((env->gregs[PARAM1] && 0xff) == 0);
> 
> Guess that should be a single '&'.

Oh, ooh. Yes, please fix.

Thanks,
Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

  reply	other threads:[~2008-07-16 12:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-16 11:31 [Qemu-devel] [4875] Remove unintended dereference, kills a warning (Jan Kiszka) Andrzej Zaborowski
2008-07-16 11:36 ` Laurent Desnogues
2008-07-16 12:10   ` Jan Kiszka [this message]
2008-07-16 12:04 ` Andreas Schwab
2008-07-16 12:30   ` Laurent Desnogues
2008-07-16 12:35     ` [Qemu-devel] " Jan Kiszka
2008-07-19  6:24       ` andrzej zaborowski
2008-08-18  7:13         ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487DE519.3030202@web.de \
    --to=jan.kiszka@web.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.