All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] v1.3.4-rc1 released
Date: Thu, 17 Jul 2008 06:21:32 -0400	[thread overview]
Message-ID: <487F1D2C.4050409@gmail.com> (raw)
In-Reply-To: <20080717082426.9823F240EE@gemini.denx.de>

Wolfgang Denk wrote:
> In message <487EE97F.8010603@denx.de> you wrote:
>> Didnt know this ... so we must change something in common/main.c :-(
> 
> Yes.
> 
>> Whats with something like this?
> 
> Looks way too complicated to me. What do you think about the PATCH /
> RFC I posted yesterday?
> 
> Best regards,
> 
> Wolfgang Denk

I presume you considered and discarded using a special #define (e.g. 
CONFIG_AUTOBOOT_PROMPT_0) for the no value case.  It only hurts our 
#ifdef hellcount a little and changes our "touch" count from <all> to 5 
(4 if I fix sacsng).

diff --git a/common/main.c b/common/main.c
index 79ad291..09e6033 100644
--- a/common/main.c
+++ b/common/main.c
@@ -115,8 +115,10 @@ static __inline__ int abortboot(int bootdelay)
         u_int presskey_max = 0;
         u_int i;

-#  ifdef CONFIG_AUTOBOOT_PROMPT
+#  if defined(CONFIG_AUTOBOOT_PROMPT)
         printf(CONFIG_AUTOBOOT_PROMPT, bootdelay);
+#  elif defined(CONFIG_AUTOBOOT_PROMPT_0)
+       c
  #  endif

  #  ifdef CONFIG_AUTOBOOT_DELAY_STR

  parent reply	other threads:[~2008-07-17 10:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-17  6:41 [U-Boot-Users] v1.3.4-rc1 released Heiko Schocher
2008-07-17  8:24 ` Wolfgang Denk
2008-07-17  8:59   ` Heiko Schocher
2008-07-17 10:21   ` Jerry Van Baren [this message]
2008-07-17 11:48     ` Jerry Van Baren
2008-07-17 12:53       ` Heiko Schocher
     [not found] <mailman.767415.1216216547.5026.u-boot-users@lists.sourceforge.net>
2008-07-16 19:29 ` Heiko Schocher
2008-07-16 21:14   ` Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2008-07-16 11:18 Wolfgang Denk
2008-07-16 13:32 ` Jerry Van Baren
2008-07-23 19:12 ` Scott Wood
2008-07-29 14:37   ` Wolfgang Denk
2008-07-29 16:48     ` Scott Wood
2008-07-31  8:31       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487F1D2C.4050409@gmail.com \
    --to=gvb.uboot@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.