All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org,
	Gabriele Trombetti <g.trombetti.lkrnl1213@logicschema.com>,
	yakui.zhao@intel.com
Subject: Re: [patch] ACPI: stop complaints about interrupt link End Tags and blank IRQ descriptors
Date: Thu, 17 Jul 2008 14:41:28 +0200	[thread overview]
Message-ID: <487F3DF8.60305@firstfloor.org> (raw)
In-Reply-To: <200807150942.57756.bjorn.helgaas@hp.com>

Bjorn Helgaas wrote:
> Silently ignore _PRS End Tags.  We already ignore Start Dependent Functions in
> _PRS, and we already ignore End Tags in _CRS, so we might as well ignore End
> Tags in _PRS as well.
> 
> Silently ignore _PRS IRQ descriptors that mention no interrupts.  The spec
> allows this (section 6.4.2.1 in ACPI 3.0b spec), and it probably means the
> interrupt link can't be configured at all.
> 
> This patch doesn't change any functional behavior; it just removes confusing
> complaints like these:
> 
>     ACPI: Blank IRQ resource
>     ACPI: Resource is not an IRQ entry
> 
> when parsing _PRS data "23 00 00 18 79 00" from an IBM xSeries 335 dual
> Pentium IV Xeon 2.40 GHz machine.  For more details, see
>     http://bugzilla.kernel.org/show_bug.cgi?id=11049
> 
> The "23 00 00 18" part is a three-byte-long small IRQ resource with no bits set
> in the IRQ mask ("00 00"), and level-triggered, active low, shareable ("18").
> 
> The "79 00" is an End Tag (type 0x7).  It is superfluous since there is no
> Start Dependent Function tag and there are no resources after it, but it is
> harmless.
> 
> Thanks to Gabriele Trombetti <g.trombetti.lkrnl1213@logicschema.com>
> (aka Kurk) for reporting this and testing the patch.

Looks good, thanks.

-Andi

      reply	other threads:[~2008-07-17 12:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-15 15:42 [patch] ACPI: stop complaints about interrupt link End Tags and blank IRQ descriptors Bjorn Helgaas
2008-07-17 12:41 ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487F3DF8.60305@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=g.trombetti.lkrnl1213@logicschema.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=yakui.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.