All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: David Miller <davem@davemloft.net>,
	linux-netdev <netdev@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] sctp: remove unnecessary byteshifting, calculate crc in	big-endian
Date: Thu, 17 Jul 2008 15:24:31 -0400	[thread overview]
Message-ID: <487F9C6F.3080802@hp.com> (raw)
In-Reply-To: <1216322461.6029.3.camel@brick>

Harvey Harrison wrote:
> On Thu, 2008-07-10 at 08:43 -0400, Vlad Yasevich wrote:
>> Harvey Harrison wrote:
>>> On Wed, 2008-07-09 at 16:59 -0400, Vlad Yasevich wrote:
>>>> Harvey Harrison wrote:
>>>>> -	__u32 crc32 = 0;
>>>>> +	__be32 crc32 = cpu_to_be32(0);
>>>> Does this actually do anything?
>>>>
>>>> Otherwise, good clean-up. Thanks
>>>>
>>> Keeps sparse happy.
>> Wouldn't just a (__force __be32)0 do the same thing and
>> avoid useless byte swapping on little endian?
>>
> 
> Vlad, do you want me to revise the patch, or were you taking it as is?
> 
> Harvey
> 


Could you fix it please.

Thanks
-vlad

  reply	other threads:[~2008-07-17 19:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-04  1:13 [PATCH] sctp: remove unnecessary byteshifting, calculate crc in big-endian Harvey Harrison
2008-07-09 20:59 ` Vlad Yasevich
2008-07-10  1:01   ` Harvey Harrison
2008-07-10 12:43     ` Vlad Yasevich
2008-07-11 18:07       ` Harvey Harrison
2008-07-17 19:21       ` Harvey Harrison
2008-07-17 19:24         ` Vlad Yasevich [this message]
2008-07-17 19:31           ` [PATCHv2] sctp: remove unnecessary byteshifting, calculate directly " Harvey Harrison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487F9C6F.3080802@hp.com \
    --to=vladislav.yasevich@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=harvey.harrison@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.