From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rene Herman Subject: Re: [boot crash, bisected] in 9f240a55 "ALSA: opti93x: use cs4231 lib" Date: Fri, 18 Jul 2008 14:39:08 +0200 Message-ID: <48808EEC.3000409@keyaccess.nl> References: <20080717170657.GA14593@elte.hu> <487F9B9B.2010905@keyaccess.nl> <487F9FA1.7020101@keyaccess.nl> <48806017.1040307@keyaccess.nl> <20080718142849.f11ce4c8.krzysztof.h1@poczta.fm> <48808E39.4060404@keyaccess.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtpq1.groni1.gr.home.nl (smtpq1.groni1.gr.home.nl [213.51.130.200]) by alsa0.perex.cz (Postfix) with ESMTP id E96C024471 for ; Fri, 18 Jul 2008 14:37:10 +0200 (CEST) In-Reply-To: <48808E39.4060404@keyaccess.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Krzysztof Helt Cc: ALSA development , Krzysztof Helt , Takashi Iwai , LKML , "Rafael J. Wysocki" , Ingo Molnar , Rene Herman List-Id: alsa-devel@alsa-project.org On 18-07-08 14:36, Rene Herman wrote: > On 18-07-08 14:28, Krzysztof Helt wrote: > >> On Fri, 18 Jul 2008 11:19:19 +0200 >> Rene Herman wrote: >> >>> On 17-07-08 21:38, Rene Herman wrote: >>> >>>> On 17-07-08 21:20, Rene Herman wrote: >>>> >>>>> On 17-07-08 20:40, Takashi Iwai wrote: >>>>> >>>>>> Could you try the patch below? >>> This bug was uncovered by !CONFIG_PNP and we had trouble in this >>> driver due to that before so was rewriting the init to be a generic >>> multi-card ALSA init but, actually, not much point. >>> >> >> The bug was introduced by the patch as it used (tried to free) the >> codec pointer >> before it was assigned any value. It happened only if the card was >> missing and >> I didn't test the driver on such a configuration. My mistake. The >> CONFIG_PNP >> setting makes no difference. > > Yes it does. Note how the ISA match method fails due to "if (isapnp)" > with CONFIG_PNP and isapnp being initialized to 1. I did test without > the hardware but didn't see it fail due to that. (but please note, yes, "uncovered", not "caused". the bug was indeed in this commit and was fixed by Takashi). Rene. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757971AbYGRMhZ (ORCPT ); Fri, 18 Jul 2008 08:37:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755932AbYGRMhM (ORCPT ); Fri, 18 Jul 2008 08:37:12 -0400 Received: from smtpq1.groni1.gr.home.nl ([213.51.130.200]:54090 "EHLO smtpq1.groni1.gr.home.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755968AbYGRMhK (ORCPT ); Fri, 18 Jul 2008 08:37:10 -0400 Message-ID: <48808EEC.3000409@keyaccess.nl> Date: Fri, 18 Jul 2008 14:39:08 +0200 From: Rene Herman User-Agent: Thunderbird 2.0.0.14 (X11/20080421) MIME-Version: 1.0 To: Krzysztof Helt CC: Takashi Iwai , Ingo Molnar , Jaroslav Kysela , LKML , ALSA development , "Rafael J. Wysocki" , Rene Herman , Krzysztof Helt Subject: Re: [boot crash, bisected] in 9f240a55 "ALSA: opti93x: use cs4231 lib" References: <20080717170657.GA14593@elte.hu> <487F9B9B.2010905@keyaccess.nl> <487F9FA1.7020101@keyaccess.nl> <48806017.1040307@keyaccess.nl> <20080718142849.f11ce4c8.krzysztof.h1@poczta.fm> <48808E39.4060404@keyaccess.nl> In-Reply-To: <48808E39.4060404@keyaccess.nl> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.0 (-) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18-07-08 14:36, Rene Herman wrote: > On 18-07-08 14:28, Krzysztof Helt wrote: > >> On Fri, 18 Jul 2008 11:19:19 +0200 >> Rene Herman wrote: >> >>> On 17-07-08 21:38, Rene Herman wrote: >>> >>>> On 17-07-08 21:20, Rene Herman wrote: >>>> >>>>> On 17-07-08 20:40, Takashi Iwai wrote: >>>>> >>>>>> Could you try the patch below? >>> This bug was uncovered by !CONFIG_PNP and we had trouble in this >>> driver due to that before so was rewriting the init to be a generic >>> multi-card ALSA init but, actually, not much point. >>> >> >> The bug was introduced by the patch as it used (tried to free) the >> codec pointer >> before it was assigned any value. It happened only if the card was >> missing and >> I didn't test the driver on such a configuration. My mistake. The >> CONFIG_PNP >> setting makes no difference. > > Yes it does. Note how the ISA match method fails due to "if (isapnp)" > with CONFIG_PNP and isapnp being initialized to 1. I did test without > the hardware but didn't see it fail due to that. (but please note, yes, "uncovered", not "caused". the bug was indeed in this commit and was fixed by Takashi). Rene.