From: Dave Winchell <dwinchell@virtualiron.com>
To: "Yu, Ke" <ke.yu@intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
xen-devel@lists.xensource.com,
Dave Winchell <dwinchell@virtualiron.com>,
Keir Fraser <keir.fraser@eu.citrix.com>,
"Wei, Gang" <gang.wei@intel.com>
Subject: Re: [PATCH] Deferrable Timer
Date: Fri, 18 Jul 2008 11:29:24 -0400 [thread overview]
Message-ID: <4880B6D4.4020906@virtualiron.com> (raw)
In-Reply-To: <1104166E0B63A341805FDB977862AAD201BF4DE8@pdsmsx414.ccr.corp.intel.com>
Ke,
Yu, Ke wrote:
>Dave,
>
>Glad to see there is deferrable timer application. Please go ahead with
>that. And I will keep you updated if there is finding in my side.
>
ok.
>
>
>BTW, Could you please elaborate more on the "guest-handles-missed-tick"
>case? Since there is no need to inject missed tick to guest, which timer
>would be used as deferrable timer?
>
>
Hpet.c uses set_timer for hpet comparator/timer 0. When that timer expires,
a clock interrupt may be injected to the guest. This timer
is normally set to expire at the next period boundary.
We could, instead, have it expire over a range of say, several periods.
Vpt.c works in a similar fashion for its periodic timer. Other clocksources,
e.g. pit, rtc, are layred on vpt.c with interface create_periodic_timer.
I can imagine an option passed to create_periodic_timer signifying that
a deferrable timer may be used.
Ideally, the deferrable timer would have an option where a set of allowable
timeout values, rather than a range, could be provided. If it had this
option, we could keep
the timeouts on the integer*period time line. Otherwise I need to warp
the comparator
as discussed below. I anticipate that there may be some problems with
warping.
I realize that specifying a range gives you more options for combining
timeouts.
I don't mind trying to solve the warping problem.
One further option would be a deferrable timer with a range fallowed by
a non-deferrable
timer to get back on the integer*period timeline for interrupt delivery.
thanks,
Dave
>Best Regards
>Ke
>
>Dave Winchell wrote:
>
>
>>Ke,
>>
>>One would think that hpet or vpt support for the
>>guest-handles-missed-ticks policy would be a good application for a
>>deferrable timer.
>>If a deferrable timer were used, then the comparator (cmp) would have
>>to
>>be warped to a non-integer multiple of the period. This is because
>>Linux reads the comparator register to estimate the delay since the
>>interrupt
>>was posted.
>>I don't think warping like this will be a problem. At some point, I
>>can test this.
>>
>>I think we could use the deferrable timer for the
>>guest-does-not-handle-missed-ticks
>>policy as well.
>>
>>Any investigation that you want to do in the platform timer area would
>>be fine.
>>Or I can do it, but that will probably be after I do the vpt.c/hpet.c
>>integration
>>work.
>>
>>thanks,
>>Dave
>>
>>
>>
>>>Best Regards
>>>Ke
>>>
>>>_______________________________________________
>>>Xen-devel mailing list
>>>Xen-devel@lists.xensource.com
>>>http://lists.xensource.com/xen-devel
>>>
>>>
>
>
>
next prev parent reply other threads:[~2008-07-18 15:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 12:54 [PATCH] Deferrable Timer Yu, Ke
2008-07-17 13:15 ` Keir Fraser
2008-07-17 13:55 ` Yu, Ke
2008-07-17 14:14 ` Dave Winchell
2008-07-18 14:37 ` Yu, Ke
2008-07-18 15:11 ` Yu, Ke
2008-07-18 15:44 ` Dave Winchell
2008-07-18 15:29 ` Dave Winchell [this message]
2008-07-21 5:46 ` Tian, Kevin
2008-07-22 15:56 ` Dave Winchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4880B6D4.4020906@virtualiron.com \
--to=dwinchell@virtualiron.com \
--cc=gang.wei@intel.com \
--cc=ke.yu@intel.com \
--cc=keir.fraser@eu.citrix.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.