From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jan Beulich <jbeulich@novell.com>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org,
hpa@zytor.com
Subject: Re: [PATCH] x86: clean up pgd_{c,d}tor
Date: Fri, 18 Jul 2008 09:08:28 -0700 [thread overview]
Message-ID: <4880BFFC.9060108@goop.org> (raw)
In-Reply-To: <4880D1A0.76E4.0078.0@novell.com>
Jan Beulich wrote:
>>>> Jeremy Fitzhardinge <jeremy@goop.org> 18.07.08 16:52 >>>
>>>>
>> Jan Beulich wrote:
>>
>>> Giving pgd_ctor() a properly typed parameter allows eliminating a local
>>> variable. Adjust pgd_dtor() to match.
>>>
>>> Also, pgd_ctor()'s clearing of the memory is redundant with the
>>> GFP_ZERO used for allocating it.
>>>
>>>
>> Ack to the parameter type change. But there's already a patch in git to
>> remove the redundant clear.
>>
>
> Again, I can't see this in my just refreshed tree - am I doing things wrong?
> Or is this due to the myriads of topic branches (which of course I don't
> check out all)?
>
No, the changes are in mainline linux-2.6.git, though you should be able
to find them in master in tip.git.
J
next prev parent reply other threads:[~2008-07-18 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 12:47 [PATCH] x86: clean up pgd_{c,d}tor Jan Beulich
2008-07-18 14:52 ` Jeremy Fitzhardinge
2008-07-18 15:23 ` Jan Beulich
2008-07-18 16:08 ` Jeremy Fitzhardinge [this message]
2008-07-18 16:15 ` Jeremy Fitzhardinge
2008-07-18 23:15 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4880BFFC.9060108@goop.org \
--to=jeremy@goop.org \
--cc=hpa@zytor.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.