From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Soumyadip Das Mahapatra <soumya.linux@yahoo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Surprising Code In sound/core/pcm_native.c In Recent Git Tree
Date: Fri, 18 Jul 2008 23:02:01 +0200 [thread overview]
Message-ID: <488104C9.6080108@s5r6.in-berlin.de> (raw)
In-Reply-To: <416584.18514.qm@web59516.mail.ac4.yahoo.com>
Soumyadip Das Mahapatra wrote:
> When i was reading the code in sound/core/pcm_native.c in
> recent git tree, i got stuck in line no 3258. It is something
> like this
> snd_assert(substream != NULL, goto out);
>
> That (goto statement) surprised me for a while unless i came to
> know snd_assert() is a macro (as expected!). Previous version
> too had a return statement in it.
>
> The point is that can we have a nicer code? Because this type
> of code is sometimes __CONFUSING__.
Curious. The "goto out", "return -EIO" and friends are not compiled in
if CONFIG_SND_DEBUG is not set.
Why would anybody want a debug macro to exit from functions?
BTW, grep tells me there are 829 occurrences of snd_assert in linux 2.6.26.
--
Stefan Richter
-=====-==--- -=== =--=-
http://arcgraph.de/sr/
prev parent reply other threads:[~2008-07-18 21:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 20:37 Surprising Code In sound/core/pcm_native.c In Recent Git Tree Soumyadip Das Mahapatra
2008-07-18 21:02 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488104C9.6080108@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=soumya.linux@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.