From: Avi Kivity <avi@qumranet.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 5/5] Remove change to TARGET_PAGE_SIZE
Date: Sat, 19 Jul 2008 10:50:33 +0300 [thread overview]
Message-ID: <48819CC9.9070504@qumranet.com> (raw)
In-Reply-To: <1216326515-20920-5-git-send-email-aliguori@us.ibm.com>
Anthony Liguori wrote:
> This is unnecessary sign-extension will do the Right Thing.
Well, I think it is better to be explicit about it, but we do want to
stay close to qemu, so I applied this.
> Paul Brook also
> objects strongly to it because it's unnecessary.
>
The smaller the patch, the stronger the objections.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2008-07-19 7:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 20:28 [PATCH 1/5] Remove hypercall device Anthony Liguori
2008-07-17 20:28 ` [PATCH 2/5] Remove duplicate monitor definition Anthony Liguori
2008-07-17 20:28 ` [PATCH 3/5] Remove whitespace in VMDK code Anthony Liguori
2008-07-19 7:45 ` Avi Kivity
2008-07-19 14:37 ` Anthony Liguori
2008-07-20 8:47 ` Avi Kivity
2008-07-20 14:19 ` Anthony Liguori
2008-07-17 20:28 ` [PATCH 4/5] Remove unnecessary definition of hack_around_tap Anthony Liguori
2008-07-17 20:28 ` [PATCH 5/5] Remove change to TARGET_PAGE_SIZE Anthony Liguori
2008-07-19 7:50 ` Avi Kivity [this message]
2008-07-19 7:49 ` [PATCH 1/5] Remove hypercall device Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48819CC9.9070504@qumranet.com \
--to=avi@qumranet.com \
--cc=aliguori@us.ibm.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.